Bug 1874301 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
We have a report that the menu doesn't get bigger on Steam Deck, and it seems we use that behavior only on Windows: https://searchfox.org/mozilla-central/rev/961a9e56a0b5fa96ceef22c61c5e75fb6ba53395/browser/base/content/browser.js#1951-1953

```js
    if (AppConstants.platform == "win") {
      MenuTouchModeObserver.init();
    }
```

That doesn't seem like a good condition, can we instead use something like [`PlatformSupportsTouch()`](https://searchfox.org/mozilla-central/rev/961a9e56a0b5fa96ceef22c61c5e75fb6ba53395/dom/events/TouchEvent.cpp#198) as the condition? Do we have a good reason to keep limiting this to Windows?
Revision 1 by
on 
We have a report that the menu doesn't get bigger by touch input  on Steam Deck, and it seems we use that behavior only on Windows: https://searchfox.org/mozilla-central/rev/961a9e56a0b5fa96ceef22c61c5e75fb6ba53395/browser/base/content/browser.js#1951-1953

```js
    if (AppConstants.platform == "win") {
      MenuTouchModeObserver.init();
    }
```

That doesn't seem like a good condition, can we instead use something like [`PlatformSupportsTouch()`](https://searchfox.org/mozilla-central/rev/961a9e56a0b5fa96ceef22c61c5e75fb6ba53395/dom/events/TouchEvent.cpp#198) as the condition? Do we have a good reason to keep limiting this to Windows?
Revision 2 by
on 
We have a report that the menu doesn't get bigger by touch input on Steam Deck, and it seems we use that behavior only on Windows: https://searchfox.org/mozilla-central/rev/961a9e56a0b5fa96ceef22c61c5e75fb6ba53395/browser/base/content/browser.js#1951-1953

```js
    if (AppConstants.platform == "win") {
      MenuTouchModeObserver.init();
    }
```

That doesn't seem like a good condition, can we instead use something like [`PlatformSupportsTouch()`](https://searchfox.org/mozilla-central/rev/961a9e56a0b5fa96ceef22c61c5e75fb6ba53395/dom/events/TouchEvent.cpp#198) as the condition? Do we have a good reason to keep limiting this to Windows?

Back to Bug 1874301 Comment 0