Bug 1874489 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to mozillabugs from comment #3)
> (In reply to mozillabugs from comment #2)
> > (In reply to Andrew McCreight [:mccr8] from comment #1)
> > > FWIW, code coverage data on SearchFox says we are running at least some of the code in OpenTypeSTAT::Parse.
> > 
> > This is interesting, as SearchFox search says it's not called, yet it gets built into the executable, so something must reference it (the linker should remove unreferenced code). Aha! It gets called when visiting...wait for it....google.com . So this isn't latent. The caller in this case is `Font::ParseTable()` in `gfx\ots\src\ots.cc`, so SearchFox is missing a live one. I'll get a POC working soon.
Revision 1 by
on 
(In reply to mozillabugs from comment #3)
> (In reply to mozillabugs from comment #2)
> > (In reply to Andrew McCreight [:mccr8] from comment #1)
> > > FWIW, code coverage data on SearchFox says we are running at least some of the code in OpenTypeSTAT::Parse.
> > 
> > This is interesting, as SearchFox search says it's not called, yet it gets built into the executable, so something must reference it (the linker should remove unreferenced code). Aha! It gets called when visiting...wait for it....google.com . So this isn't latent. The caller in this case is `Font::ParseTable()` in `gfx\ots\src\ots.cc`, so SearchFox is missing a live one. I'll get a POC working soon.

Sorry about the multiple replies; I clicked the wrong icon.
Revision 2 by
on 
(In reply to mozillabugs from comment #3)
> (In reply to mozillabugs from comment #2)
> > (In reply to Andrew McCreight [:mccr8] from comment #1)
> > > FWIW, code coverage data on SearchFox says we are running at least some of the code in OpenTypeSTAT::Parse.
> > 
> > This is interesting, as SearchFox search says it's not called, yet it gets built into the executable, so something must reference it (the linker should remove unreferenced code). Aha! It gets called when visiting...wait for it....google.com . So this isn't latent. The caller in this case is `Font::ParseTable()` in `gfx\ots\src\ots.cc`, so SearchFox is missing a live one. I'll try to get a POC working soon.

Sorry about the multiple replies; I clicked the wrong icon.

Back to Bug 1874489 Comment 4