(In reply to Daniel Bodea [:danibodea] from comment #4) > I am attempting to verify this fix, but it is not clear what the change is and how to verify it. > > I have found these steps in [Phabricator ticket](https://phabricator.services.mozilla.com/D200078), however, I can't seem to understand how to make the specific screen appear in the about:welcome flow: > > in about:config include the following screens in browser.aboutwelcome.screens > route to about:welcome > notice the privacy notice link rendered above the Next button > ensure link is clickable > on <800px notice the link in center alignment nested above the Next button > set browser.shopping.experience2023.active and browser.shopping.experience2023.enabled to true and route to amazon.com > ensure no visual regression in the opt-in screen privacy notice link as well as by resizing the container > > Can you explain step 1? The pref "browser.aboutwelcome.screens" already exists as string type, but it has no value, by default. What value should it have? Thank you. Hi there! The the following `screens` is a link in the phabricator test step which has the screen array in a gist that you would put into screens pref. Here's the link from the test plan: https://gist.github.com/nuggetsnegin/7c72eeccb48a3a60b63e35dab6a6da51 The link will then have a JSON that uses a screen that uses this configuration change so you can test the changes. Thanks!
Bug 1877557 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Daniel Bodea [:danibodea] from comment #4) > I am attempting to verify this fix, but it is not clear what the change is and how to verify it. > > I have found these steps in [Phabricator ticket](https://phabricator.services.mozilla.com/D200078), however, I can't seem to understand how to make the specific screen appear in the about:welcome flow: > > in about:config include the following screens in browser.aboutwelcome.screens > route to about:welcome > notice the privacy notice link rendered above the Next button > ensure link is clickable > on <800px notice the link in center alignment nested above the Next button > set browser.shopping.experience2023.active and browser.shopping.experience2023.enabled to true and route to amazon.com > ensure no visual regression in the opt-in screen privacy notice link as well as by resizing the container > > Can you explain step 1? The pref "browser.aboutwelcome.screens" already exists as string type, but it has no value, by default. What value should it have? Thank you. Hi there! In the test step, `screens` is a link in the phabricator test step which has the screen array in a gist that you would copy snd paste into browser.aboutwelcome.screens pref. Here's the link from the test plan: https://gist.github.com/nuggetsnegin/7c72eeccb48a3a60b63e35dab6a6da51 The link will has JSON that uses a screen that implements the configuration change so you can test the changes. Thanks!
(In reply to Daniel Bodea [:danibodea] from comment #4) > I am attempting to verify this fix, but it is not clear what the change is and how to verify it. > > I have found these steps in [Phabricator ticket](https://phabricator.services.mozilla.com/D200078), however, I can't seem to understand how to make the specific screen appear in the about:welcome flow: > > in about:config include the following screens in browser.aboutwelcome.screens > route to about:welcome > notice the privacy notice link rendered above the Next button > ensure link is clickable > on <800px notice the link in center alignment nested above the Next button > set browser.shopping.experience2023.active and browser.shopping.experience2023.enabled to true and route to amazon.com > ensure no visual regression in the opt-in screen privacy notice link as well as by resizing the container > > Can you explain step 1? The pref "browser.aboutwelcome.screens" already exists as string type, but it has no value, by default. What value should it have? Thank you. Hi there! In the test step, `screens` is a link in the phabricator test step which has the screen array in a gist that you would copy and paste into browser.aboutwelcome.screens pref. Here's the link from the test plan: https://gist.github.com/nuggetsnegin/7c72eeccb48a3a60b63e35dab6a6da51 The link will has JSON that uses a screen that implements the configuration change so you can test the changes. Thanks!