Bug 1878211 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I verified that eeejay's attached patch fixes the crash, testing a local ASAN debug+opt build on my attached testcase 1 with steps in comment 12.

In a stock ASAN debug+opt build, both (1) and (2) from comment 12 instantly crash for me.
When I build with eeejay's patch, I don't crash.
Revision 1 by
on 
I verified that eeejay's attached patch fixes the crash, testing a local ASAN debug+opt build on my attached testcase 1 with steps in comment 12.

In a stock ASAN debug+opt build, both approaches (1) and (2) from comment 12 instantly crash for me, with this fatal asan error:
```
==384424==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x504000113e34 at pc 0x7f39116ae4e8 bp 0x7ffdec65ac50 sp 0x7ffdec65ac48
READ of size 4 at 0x504000113e34 thread T0 (file:// Content)
```
When I build with eeejay's patch, I don't crash.
Revision 2 by
on 
I verified that eeejay's attached patch fixes the crash, testing a local ASAN debug+opt build on my attached testcase 1 with steps in comment 12.

In a stock ASAN debug+opt build, both approaches (1) and (2) from comment 12 instantly crash for me, with this fatal asan error:
```
==384424==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x504000113e34 at pc 0x7f39116ae4e8 bp 0x7ffdec65ac50 sp 0x7ffdec65ac48
READ of size 4 at 0x504000113e34 thread T0 (file:// Content)
```
When I apply eeejay's patch and rebuild and repeat the test, I don't crash.

Back to Bug 1878211 Comment 14