I can reproduce this. I had opened **`[DON'T LOAD]`** https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650 **`[DON'T LOAD]`** in a tab. My browser was crashing consistently a little bit after startup with this signature. I managed to catch it in a debugger, we're trying to send a very big message over IPC: ``` (lldb) p aMessage.mTuple.mFirstA->header_->payload_size (uint32_t) 344522136 ``` To be clear, this page is a bit ridiculous: it has an anchor element for every line of source, and there's more than 5 million lines. But the `resultsForProcess` at https://searchfox.org/mozilla-central/rev/261005fcc4d6f8b64189946958211259fb45e9e1/docshell/base/BaseHistory.cpp#220 seems to contain more than 3 million URIs of the form: ``` https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.1 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.2 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.3 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.4 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.5 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.6 … ``` I'm not sure why we need to notify about unvisited links, but we shouldn't be crashing here. There are multiple things we can do: limit the message size (by sending in chunks), maybe figure out a better encoding for multiple hrefs that are the same but have a different ref(/query), …
Bug 1884815 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I can reproduce this. I had opened `**[DON'T LOAD]** https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650 **[DON'T LOAD]**` in a tab. My browser was crashing consistently a little bit after startup with this signature. I managed to catch it in a debugger, we're trying to send a very big message over IPC: ``` (lldb) p aMessage.mTuple.mFirstA->header_->payload_size (uint32_t) 344522136 ``` To be clear, this page is a bit ridiculous: it has an anchor element for every line of source, and there's more than 5 million lines. But the `resultsForProcess` at https://searchfox.org/mozilla-central/rev/261005fcc4d6f8b64189946958211259fb45e9e1/docshell/base/BaseHistory.cpp#220 seems to contain more than 3 million URIs of the form: ``` https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.1 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.2 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.3 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.4 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.5 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.6 … ``` I'm not sure why we need to notify about unvisited links, but we shouldn't be crashing here. There are multiple things we can do: limit the message size (by sending in chunks), maybe figure out a better encoding for multiple hrefs that are the same but have a different ref(/query), …
I can reproduce this. I had opened **[DON'T LOAD]**` https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650 `**[DON'T LOAD]** in a tab. My browser was crashing consistently a little bit after startup with this signature. I managed to catch it in a debugger, we're trying to send a very big message over IPC: ``` (lldb) p aMessage.mTuple.mFirstA->header_->payload_size (uint32_t) 344522136 ``` To be clear, this page is a bit ridiculous: it has an anchor element for every line of source, and there's more than 5 million lines. But the `resultsForProcess` at https://searchfox.org/mozilla-central/rev/261005fcc4d6f8b64189946958211259fb45e9e1/docshell/base/BaseHistory.cpp#220 seems to contain more than 3 million URIs of the form: ``` https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.1 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.2 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.3 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.4 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.5 https://hg.mozilla.org/mozilla-central/rev/9b2a99adc05e53cd4010de512f50118594756650#l1.6 … ``` I'm not sure why we need to notify about unvisited links, but we shouldn't be crashing here. There are multiple things we can do: limit the message size (by sending in chunks), maybe figure out a better encoding for multiple hrefs that are the same but have a different ref(/query), …