STR: 1. Right-click a page and choose "Take Screenshot" 2. Look at the buttons in the top right corner, to save visible vs. full-page. Pay attention to which one is first. 3. Now toggle the about:config pref `screenshots.browser.component.enabled` to change its value. 4. Repeat steps 1-2. ACTUAL RESULTS: The buttons are in a different order depending on the value of that pref: - With `screenshots.browser.component.enabled` = true, "Save Visible" on the left. - With `screenshots.browser.component.enabled` = false, "Save Full Page" is on the left. Nightly has the pref defaulting to `true`, so it shows the former ordering. Release has the pref defaulting to `false`, so it shows the latter EXPECTED RESULTS: They probably should be in the same order that they were before, to benefit from muscle-memory & so people who use this feature don't get spooked by stuff unnecessarily moving? (Unless we're making a conscious choice to reorder them as part of this rewrite, if the new order is definitively better for some reason. If that's the case, feel free to close this.) See attached screenshot, with the `true` pref on top and the `false` pref on bottom.
Bug 1886843 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
STR: 1. Right-click a page and choose "Take Screenshot" 2. Look at the buttons in the top right corner, to save visible vs. full-page. Pay attention to which one is first. 3. Now toggle the about:config pref `screenshots.browser.component.enabled` to change its value. 4. Repeat steps 1-2. ACTUAL RESULTS: The buttons are in a different order depending on the value of that pref: - With `screenshots.browser.component.enabled` = true, the button on the left is "Save Visible". - With `screenshots.browser.component.enabled` = false, the button on the left is "Save Full Page. Nightly has the pref defaulting to `true`, so it shows the former ordering. Release has the pref defaulting to `false`, so it shows the latter EXPECTED RESULTS: They probably should be in the same order that they were before, to benefit from muscle-memory & so people who use this feature don't get spooked by stuff unnecessarily moving? (Unless we're making a conscious choice to reorder them as part of this rewrite, if the new order is definitively better for some reason. If that's the case, feel free to close this.) See attached screenshot, with the `true` pref on top and the `false` pref on bottom.