Bug 1887554 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Mayank Bansal from comment #3)
> Bisection:
> Bug 1749047 - Bring GetExtraData back to ToMediaRawData r=media-playback-reviewers,padenot
> 
> `GetExtraData`, which is removed in D196209, must be added back to
> generate the extra data for H264 AVCC format, so the VideoEncoder can
> forward those info with the encoded data.
> 
> Differential Revision: https://phabricator.services.mozilla.com/D197138

On Windows, this code should only be used when H264 is encoded [by libx264](https://searchfox.org/mozilla-central/rev/b220e40ff2ee3d10ce68e07d8a8a577d5558e2a2/dom/media/platforms/ffmpeg/FFmpegVideoEncoder.cpp#697) through FFmpeg. Do you test it with libx264? From the uploaded [about:support](https://bug1887554.bmoattachments.org/attachment.cgi?id=9392952), H264 hardware decoding is supported, I wonder if the hardware encoding is also supported. If it is, then H264 data will be encoded by [WMFMediaDataEncoder](https://searchfox.org/mozilla-central/rev/b220e40ff2ee3d10ce68e07d8a8a577d5558e2a2/dom/media/platforms/wmf/WMFMediaDataEncoder.cpp#171) rather then FFmpegVideoEncoder.
Revision 1 by
on 
(In reply to Mayank Bansal from comment #3)
> Bisection:
> Bug 1749047 - Bring GetExtraData back to ToMediaRawData r=media-playback-reviewers,padenot
> 
> `GetExtraData`, which is removed in D196209, must be added back to
> generate the extra data for H264 AVCC format, so the VideoEncoder can
> forward those info with the encoded data.
> 
> Differential Revision: https://phabricator.services.mozilla.com/D197138

On Windows, this code should only be used when H264 is encoded [by libx264](https://searchfox.org/mozilla-central/rev/b220e40ff2ee3d10ce68e07d8a8a577d5558e2a2/dom/media/platforms/ffmpeg/FFmpegVideoEncoder.cpp#697) through FFmpeg. Did you test it with libx264? From the uploaded [about:support](https://bug1887554.bmoattachments.org/attachment.cgi?id=9392952), H264 hardware decoding is supported, I wonder if the hardware encoding is also supported. If it is, then H264 data will be encoded by [WMFMediaDataEncoder](https://searchfox.org/mozilla-central/rev/b220e40ff2ee3d10ce68e07d8a8a577d5558e2a2/dom/media/platforms/wmf/WMFMediaDataEncoder.cpp#171) rather then FFmpegVideoEncoder.

Back to Bug 1887554 Comment 10