Bug 1890007 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Tom S [:evilpie] from comment #6)
> Does this also fix `ങ്ക` from this [reddit post](https://www.reddit.com/r/firefox/comments/1c9jdzr/intlsegmenter_implementation_is_wrong/)?

Yes. I test `ങ്ക` via modify [this test](https://github.com/unicode-org/icu4x/blob/cb7e9151356373baac7ebb5f80d3d5c4436b57e0/components/segmenter/src/grapheme.rs#L272-L278) as the following, and `ങ്ക` produces only two grapheme cluster breaks (begin and end).

```
#[test]
fn emoji_flags() {
    // https://github.com/unicode-org/icu4x/issues/4780
    let segmenter = GraphemeClusterSegmenter::new();
    let breaks: Vec<usize> = segmenter.segment_str("ങ്ക").collect();
    assert_eq!(breaks, [0, 9]);
}
```
(In reply to Tom S [:evilpie] from comment #6)
> Does this also fix `ങ്ക` from this [reddit post](https://www.reddit.com/r/firefox/comments/1c9jdzr/intlsegmenter_implementation_is_wrong/)?

Yes. I test `ങ്ക` via modifying [this test](https://github.com/unicode-org/icu4x/blob/cb7e9151356373baac7ebb5f80d3d5c4436b57e0/components/segmenter/src/grapheme.rs#L272-L278) as the following, and `ങ്ക` produces only two grapheme cluster breaks (begin and end).

```
#[test]
fn emoji_flags() {
    // https://github.com/unicode-org/icu4x/issues/4780
    let segmenter = GraphemeClusterSegmenter::new();
    let breaks: Vec<usize> = segmenter.segment_str("ങ്ക").collect();
    assert_eq!(breaks, [0, 9]);
}
```

Back to Bug 1890007 Comment 7