Bug 1890194 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Thanks for the comment. Having looked at the related code on Fenix, I can take a stab at answering. I'm still quite new to the project, so I will still invite the more familiar folks to respond.

The overarching theme is that - I think we should match what is in the input field, but to answer:

> 1. When users select one of the entries, should we display an empty list or a full list?

I think we should show the one entry - so only the selected item. As is done on desktop.

> 2. When users select an entry and then change the content of the <input>, should we display only logins that match the updated content, an empty list or all the logins?

I would say yes. We should display the logins that match the entered content at all times - as the user changes the content of the <input>. This is also the behavior on desktop.

> 3. When users select an entry and then clear the text in the input, should we immediately display all the logins?

In Fenix code, it looks like we dismiss the current prompt [every time we receive a new select login prompt](https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptFeature.kt#436-444). So visually to the user, it will be collapsed, but when they expand it, I believe that they should see all the logins.
Thanks for the comment. Having looked at the related code on Fenix, I can take a stab at answering. I'm still quite new to the project, so I will still invite the more familiar folks to respond.

The overarching theme is that - I think we should match what is in the input field, but to answer:

> 1. When users select one of the entries, should we display an empty list or a full list?

I think we should show the matching entry (which will typically be the selected item). As is done on desktop.

> 2. When users select an entry and then change the content of the <input>, should we display only logins that match the updated content, an empty list or all the logins?

I would say yes. We should display the logins that match the entered content at all times - as the user changes the content of the <input>. This is also the behavior on desktop.

> 3. When users select an entry and then clear the text in the input, should we immediately display all the logins?

In Fenix code, it looks like we dismiss the current prompt [every time we receive a new select login prompt](https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptFeature.kt#436-444). So visually to the user, it will be collapsed, but when they expand it, I believe that they should see all the logins.

Back to Bug 1890194 Comment 7