Thanks all, super useful. Rather than adding to 'is_enterprise', how about having separate flags for the SKU or JoinDomain in the same way as we currently have OS and OS_version? This would also potentially help us make better sense of Microsoft roll-outs since they may happen at different time for different SKUs and impact these users on different schedules. We can always use is_enterprise, windows_sku or is_domain_joined as separate flags which will give us higher confidence - In the back-end a master indicator leveraging these 3 signals can also be created which should give us more flexibility if we find odd things in practice? I wonder if we should restrict this bug for creation of sku and domain joined flags since they feel actionable already. Proposal: - Windows SKU: ----New telemetry probe under system environment collects the value of HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\EditionID ----String type - Domain joined - Windows SKU: ----New telemetry probe under system environment checks if HKLM\SYSTEM\CurrentControlSet\Services\Netlogon\Parameters\JoinDomain exists ----Boolean type
Bug 1891682 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks all, super useful. Rather than adding to 'is_enterprise', how about having separate flags for the SKU or JoinDomain in the same way as we currently have OS and OS_version? This would also potentially help us make better sense of Microsoft roll-outs since they may happen at different time for different SKUs and impact these users on different schedules. We can always use is_enterprise, windows_sku or is_domain_joined as separate flags which will give us higher confidence - In the back-end a master indicator leveraging these 3 signals can also be created which should give us more flexibility if we find odd things in practice? I wonder if we should restrict this bug for creation of sku and domain joined flags since they feel actionable already. Proposal: - Windows SKU: ----New telemetry probe under system environment collects the value of HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\EditionID ----String type - Domain joined ----New telemetry probe under system environment checks if HKLM\SYSTEM\CurrentControlSet\Services\Netlogon\Parameters\JoinDomain exists ----Boolean type