Bug 1892012 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
@kcochrane What is the indented behaviour for [this set of lines](https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/customizableui/CustomizableUI.sys.mjs#378-386)? As far as I can tell `shouldAdd` will always be `false` in this case, which will mean it won't have any effect [further down](https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/customizableui/CustomizableUI.sys.mjs#388-398).
Revision 1 by
on 
@kcochrane What is the intented behaviour for [this set of lines](https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/customizableui/CustomizableUI.sys.mjs#378-386)? As far as I can tell `shouldAdd` will always be `false` in this case, which will mean it won't have any effect [further down](https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/customizableui/CustomizableUI.sys.mjs#388-398).
Revision 2 by
on 
@kcochrane What is the intended behaviour for [this set of lines](https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/customizableui/CustomizableUI.sys.mjs#378-386)? As far as I can tell `shouldAdd` will always be `false` in this case, which will mean it won't have any effect [further down](https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/customizableui/CustomizableUI.sys.mjs#388-398).

Back to Bug 1892012 Comment 5