Bug 1896758 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
After bug 1889932, the platform encoder on Windows became unavailable (see more in bug 1894072 comment #6). To have to SW H264 encoder outside of WebRTC usages, we should implement a [`MediaDataEncoder`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/platforms/PlatformEncoderModule.h#61) by GMP APIs, something like [`WebrtcGmpVideoEncoder`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/webrtc/libwebrtcglue/WebrtcGmpVideoCodec.h#158) for WebRTC cases (by [`GMPVideoEncoderProxy`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/gmp/GMPVideoEncoderProxy.h#36)).
Revision 1 by
on 
To have to SW H264 encoder outside of WebRTC usages (on Linux) if user has no FFmpeg/libx264/libopenh264 installation, we should implement a [`MediaDataEncoder`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/platforms/PlatformEncoderModule.h#61) by GMP APIs, something like [`WebrtcGmpVideoEncoder`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/webrtc/libwebrtcglue/WebrtcGmpVideoCodec.h#158) for WebRTC cases (by [`GMPVideoEncoderProxy`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/gmp/GMPVideoEncoderProxy.h#36)).
Revision 2 by
on 
To have to SW H264 encoder outside of WebRTC usages if user has no platform-encoder-support/FFmpeg/libx264/libopenh264 installation, we should implement a [`MediaDataEncoder`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/platforms/PlatformEncoderModule.h#61) by GMP APIs, something like [`WebrtcGmpVideoEncoder`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/webrtc/libwebrtcglue/WebrtcGmpVideoCodec.h#158) for WebRTC cases (by [`GMPVideoEncoderProxy`](https://searchfox.org/mozilla-central/rev/dd6e430c1bc2db90d9b3b1dd7e5215b4edc4d51a/dom/media/gmp/GMPVideoEncoderProxy.h#36)).

Back to Bug 1896758 Comment 0