Based on Harrison's evaluation above, this doesn't *seem* like a blocker to me: * Slack has a bug with how they populate the Custom Tab menu (our original Toolbar and Chrome's toolbar both behave the same) * Our new Toolbar successfully allows Instagram to populate the Custom Tab menu. It's possible that this is actually "working as intended" - e.g., if our new Toolbar logic just (circumstantially) happens to filter our broken PendingIntents, perhaps that's why Slack's menu options aren't showing up in our redesign. On the other hand, it's definitely still possible that we've broken some Custom Tab menu API, and that it needs to be fixed: but we need more information before we can make that assumption. E.g., * If someone can find an app (other than Slack) that *does* lose Custom Tab menu options in the redesign, then that'd mean we've done something wrong for sure. * If someone could debug the code path that populates the Custom Tab menu options in the redesign, perhaps you could spot the place where Slack's menu intents are getting omitted from our menu initialization. All that said: I think it's OK to leave this as a blocker for now, but if we need to cut scope later, this could be a candidate until we determine more info based on either of the above ideas.
Bug 1896961 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Based on Harrison's evaluation above, this doesn't *seem* like a blocker to me: * Slack has a bug with how they populate the Custom Tab menu (our original Toolbar and Chrome's toolbar both behave the same) * Our new Toolbar successfully allows Instagram to populate the Custom Tab menu. It's possible that this is actually "working as intended" - e.g., if our new Toolbar logic just (circumstantially) happens to filter our broken PendingIntents, perhaps that's why Slack's menu options aren't showing up in our redesign. On the other hand, it's definitely still possible that we've broken some Custom Tab menu API, and that it needs to be fixed: but we need more information before we can make that assumption. E.g., * If someone can find an app (other than Slack) that *does* lose Custom Tab menu options in the redesign, then that'd mean we've done something wrong for sure. * If someone could debug the code path that populates the Custom Tab menu options in the redesign, perhaps you could spot the place where Slack's menu intents are getting omitted from our menu initialization. **All that said: I think it's OK to leave this as a blocker for now, but if we need to cut scope later, this could be a candidate until we determine more info based on either of the above ideas.**