Bug 1897482 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Hey Liz,

I don't think this needs to be uplifted.

The only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)
	browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);
	toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.
Revision 1 by
on 
Hey Liz,

I don't think this needs to be uplifted.

The only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)
	browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);
	toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.
Revision 2 by
on 
Hey Liz,

I don't think this needs to be uplifted.

The only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` feature, which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)
	browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);
	toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.
Revision 3 by
on 
Hey Liz,

I don't think this needs to be uplifted.

The only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` feature, which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)

	browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);

	toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.
Revision 4 by
on 
Hey Liz,

I don't think this needs to be uplifted.

The only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` feature, which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)

browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);

toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.
Revision 5 by
on 
Hey Liz,

I don't think this needs to be uplifted.

The only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` feature, which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)

browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);

toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.

That being said, this is a very low-risk change and I can uplift it if still desired.
Revision 6 by
on 
Hey Liz,

I don't think this needs to be uplifted.

At the time of writing, the only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` feature, which is preffed off for the Firefox 127 release build, and is targeted for Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)

browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);

toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.

That being said, this is a very low-risk change and I can uplift it if still desired.
Revision 7 by
on 
Hey Liz,

I don't think this needs to be uplifted.

At the time of writing, the only [consumer](https://searchfox.org/mozilla-central/search?q=%28isSupportedAsToLang%7CGetTopPreferredSupportedToLang%29&path=&case=false&regexp=true) of this code currently is the `SelectTranslationsPanel` feature, which is preffed off for the Firefox 127 release build, and is targeted for release in Firefox 128. 

---

```
Searchfox Regex Query: (isSupportedAsToLang|GetTopPreferredSupportedToLang)

Core code (5 lines across 2 files)
	
Textual Occurrences (5 lines across 2 files)

browser/components/translations/content/selectTranslationsPanel.js
330	TranslationsParent.getTopPreferredSupportedToLang(),
366	: await TranslationsParent.isSupportedAsToLang(langTag);

toolkit/components/translations/actors/TranslationsParent.sys.mjs
2234	static async isSupportedAsToLang(langTag) {
2246	static async getTopPreferredSupportedToLang() {
2248	async langTag => await TranslationsParent.isSupportedAsToLang(langTag)
```

---

The defect is technically present in Firefox 126 and 127, but nothing is using this API surface.

That being said, this is a very low-risk change and I can uplift it if still desired.

Back to Bug 1897482 Comment 4