Bug 1902078 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
This is breaking NSS builds: https://github.com/mozilla/neqo/actions/runs/10157687760/job/28088270178#step:5:1306
```
cc -MMD -MF obj/cmd/shlibsign/shlibsign.shlibsign.o.d '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -DSDB_MEASURE_USE_TEMP_DIR -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I/home/runner/work/neqo/neqo/dist/Release/include/nspr -I/home/runner/work/neqo/neqo/dist/private/nss -I/home/runner/work/neqo/neqo/dist/public/nss -fPIC -pipe -ffunction-sections -fdata-sections -m64 -Werror -Wall -Wshadow -O2 -ggdb3 -fno-omit-frame-pointer -std=c99  -c ../../cmd/shlibsign/shlibsign.c -o obj/cmd/shlibsign/shlibsign.shlibsign.o
../../cmd/shlibsign/shlibsign.c: In function ‘shlibSignHMAC’:
../../cmd/shlibsign/shlibsign.c:1135:13: error: implicit declaration of function ‘SECU_HexString2SECItem’ [-Werror=implicit-function-declaration]
 1135 |         if (SECU_HexString2SECItem(NULL, &keyitem, key) == NULL) {
      |             ^~~~~~~~~~~~~~~~~~~~~~
../../cmd/shlibsign/shlibsign.c:1135:57: error: comparison between pointer and integer [-Werror]
 1135 |         if (SECU_HexString2SECItem(NULL, &keyitem, key) == NULL) {
      |                                                         ^~
cc1: all warnings being treated as errors
```
Revision 1 by
on 
This is breaking NSS builds. Surprised that our CI didn't catch that. See https://github.com/mozilla/neqo/actions/runs/10157687760/job/28088270178#step:5:1306
```
cc -MMD -MF obj/cmd/shlibsign/shlibsign.shlibsign.o.d '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -DSDB_MEASURE_USE_TEMP_DIR -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I/home/runner/work/neqo/neqo/dist/Release/include/nspr -I/home/runner/work/neqo/neqo/dist/private/nss -I/home/runner/work/neqo/neqo/dist/public/nss -fPIC -pipe -ffunction-sections -fdata-sections -m64 -Werror -Wall -Wshadow -O2 -ggdb3 -fno-omit-frame-pointer -std=c99  -c ../../cmd/shlibsign/shlibsign.c -o obj/cmd/shlibsign/shlibsign.shlibsign.o
../../cmd/shlibsign/shlibsign.c: In function ‘shlibSignHMAC’:
../../cmd/shlibsign/shlibsign.c:1135:13: error: implicit declaration of function ‘SECU_HexString2SECItem’ [-Werror=implicit-function-declaration]
 1135 |         if (SECU_HexString2SECItem(NULL, &keyitem, key) == NULL) {
      |             ^~~~~~~~~~~~~~~~~~~~~~
../../cmd/shlibsign/shlibsign.c:1135:57: error: comparison between pointer and integer [-Werror]
 1135 |         if (SECU_HexString2SECItem(NULL, &keyitem, key) == NULL) {
      |                                                         ^~
cc1: all warnings being treated as errors
```
Revision 2 by
on 
This change is breaking NSS builds. Surprised that our CI didn't catch that. See https://github.com/mozilla/neqo/actions/runs/10157687760/job/28088270178#step:5:1306
```
cc -MMD -MF obj/cmd/shlibsign/shlibsign.shlibsign.o.d '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -DSDB_MEASURE_USE_TEMP_DIR -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I/home/runner/work/neqo/neqo/dist/Release/include/nspr -I/home/runner/work/neqo/neqo/dist/private/nss -I/home/runner/work/neqo/neqo/dist/public/nss -fPIC -pipe -ffunction-sections -fdata-sections -m64 -Werror -Wall -Wshadow -O2 -ggdb3 -fno-omit-frame-pointer -std=c99  -c ../../cmd/shlibsign/shlibsign.c -o obj/cmd/shlibsign/shlibsign.shlibsign.o
../../cmd/shlibsign/shlibsign.c: In function ‘shlibSignHMAC’:
../../cmd/shlibsign/shlibsign.c:1135:13: error: implicit declaration of function ‘SECU_HexString2SECItem’ [-Werror=implicit-function-declaration]
 1135 |         if (SECU_HexString2SECItem(NULL, &keyitem, key) == NULL) {
      |             ^~~~~~~~~~~~~~~~~~~~~~
../../cmd/shlibsign/shlibsign.c:1135:57: error: comparison between pointer and integer [-Werror]
 1135 |         if (SECU_HexString2SECItem(NULL, &keyitem, key) == NULL) {
      |                                                         ^~
cc1: all warnings being treated as errors
```

Back to Bug 1902078 Comment 13