Bug 1904937 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Alastor Wu [:alwu] from comment #10)
> As I mentioned above, our eviction would only consider the data before the current index, this [call](https://searchfox.org/mozilla-central/rev/b368ed8b48c0ea8ed2f1948e4776a6fbb5976dff/dom/media/mediasource/TrackBuffersManager.cpp#2847) would result in `canEvict` will always be zero and nothing would be able to be evicted anymore because `lastKeyFrameIndex` was actually the first key frame index, not the last index. But that would be a different story if the seek target is in the buffered range, then the eviction would work as expected. 

I'm not understanding how eviction would work differently if the seek target were in the buffered range.  `lastKeyFrameIndex` and `canEvict` would still be both be zero, right?
(In reply to Alastor Wu [:alwu] from comment #10)
> As I mentioned above, our eviction would only consider the data before the current index, this [call](https://searchfox.org/mozilla-central/rev/b368ed8b48c0ea8ed2f1948e4776a6fbb5976dff/dom/media/mediasource/TrackBuffersManager.cpp#2847) would result in `canEvict` will always be zero and nothing would be able to be evicted anymore because `lastKeyFrameIndex` was actually the first key frame index, not the last index. But that would be a different story if the seek target is in the buffered range, then the eviction would work as expected. 

I'm not understanding how eviction would work differently if the seek target were in the buffered range.  `lastKeyFrameIndex` and `canEvict` would still both be zero, right?

Back to Bug 1904937 Comment 13