Bug 1906992 Comment 28 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Henri Sivonen (:hsivonen) from comment #26)
> If there are two problematic fixed strings, those could be special-cased in `idna_glue`. However, for performance reasons, I'd like to scope such a hack only to the case where `idna_glue` is being compiled as part of c-c, so that m-c-only builds don't spend time comparing every domain for "Local Folders".

Makes sense. It looks like we could special-case c-c builds by checking `mozbuild::config::MOZ_APP_NAME` (https://searchfox.org/mozilla-central/rev/01aaa47e62a2015e7641f26ab0bc2bb00ab579b8/build/rust/mozbuild/generate_buildconfig.py#104) which should be `"thunderbird"` when building as part of c-c.
(In reply to Henri Sivonen (:hsivonen) from comment #26)
> If there are two problematic fixed strings, those could be special-cased in `idna_glue`. However, for performance reasons, I'd like to scope such a hack only to the case where `idna_glue` is being compiled as part of c-c, so that m-c-only builds don't spend time comparing every domain for "Local Folders".

Makes sense. It looks like we could special-case c-c builds by checking `mozbuild::config::MOZ_APP_NAME` (https://searchfox.org/mozilla-central/rev/01aaa47e62a2015e7641f26ab0bc2bb00ab579b8/build/rust/mozbuild/generate_buildconfig.py#104), which should be `"thunderbird"` when building as part of c-c.

Back to Bug 1906992 Comment 28