> these two lines seems not to belong in a function that should show the username.
They belong there where they are, because they set the dialog in the state to show the username, be consistent with the state, and re-run the autoconfig after that. Without these lines, the dialog display is in an inconsistant state.
Bug 1907443 Comment 15 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> these two lines seems not to belong in a function that should show the username.
They belong there where they are, because they set the dialog in the state to show the username, be consistent with the state, and re-run the autoconfig after that. Without these lines, the dialog display is in an inconsistant state. Every caller who calls this showExchangeUsername() function must call these lines.