Bug 1908200 Comment 27 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #26)
> The right fix is making the `MagentaNeon` theme author specify stuff like `sidebar_text` and `sidebar_background` colors TBH....

Ah, right. So probably, the reporter used to use a theme that specified those colors, and other themes like MagentaNeon happen to not-specify these colors.

Here's one theme that does seem to set that sidebar backgorund-color (to a dark blue color), as an example:
https://addons.mozilla.org/en-US/firefox/addon/spirited-away-animated/

@littlergirl: if that^ theme successfully sets the sidebar color for you (as it does for me), then I think we're all good here and this is just a case where you picked a theme that happens to not-specify that color. :) 

(In reply to littlergirl from comment #18)
> I tried the modified version of the CSS you suggested (as seen below) and adding them to my gtk.css file does nothing:

Sorry, the CSS that I had quoted there wasn't meant as a suggested-edit for you to do -- that was just me quoting the CSS that Firefox uses internally to style this component, as a reference.  I have no idea offhand what the correct gtk.css styles would be that you could use to influence these colors (just due to my own ignorance of gtk.css internals); but you can try visiting `about:config` and creating a string-valued preference called `ui.-moz-sidebar` with value e.g. `rgb(255,0,255)` to manually make the sidebar pink.  `ui.-moz-sidebartext` will influence the color of some of the text there. The list of full about:config prefs to play with (if you like) is at https://searchfox.org/mozilla-central/rev/8c6edfe25c094e032a27722ef30f69555f556bf8/widget/nsXPLookAndFeel.cpp#215 , and you can see which (if any) of those is being used for a particular piece of the UI by using the Browser Toolbox  ( https://firefox-source-docs.mozilla.org/devtools-user/browser_toolbox/index.html ) to inspect the Firefox UI and drill down to find the relevant CSS keyword.

Possibly better, though, would be to build your own theme with Firefox Color: https://color.firefox.com/
(In reply to Emilio Cobos Álvarez (:emilio) from comment #26)
> The right fix is making the `MagentaNeon` theme author specify stuff like `sidebar_text` and `sidebar_background` colors TBH....

Ah, right. So probably, the reporter used to use a theme that specified those colors (which is the "good" state that they're remembering), and other themes like MagentaNeon happen to not-specify these colors.

Here's one theme that does seem to set that sidebar background-color (to a dark blue color), as an example of this working properly, given a theme that sets the appropriate values:
https://addons.mozilla.org/en-US/firefox/addon/spirited-away-animated/

@littlergirl: if that^ theme successfully sets the sidebar color for you (as it does for me), then I think we're all good here and this is just a case where you picked a theme that happens to not-specify that color. :) 

(In reply to littlergirl from comment #18)
> I tried the modified version of the CSS you suggested (as seen below) and adding them to my gtk.css file does nothing:

Sorry, the CSS that I had quoted there wasn't meant as a suggested-edit for you to do -- that was just me quoting the CSS that Firefox uses internally to style this component, as a reference.  I have no idea offhand what the correct gtk.css styles would be that you could use to influence these colors (just due to my own ignorance of gtk.css internals); but you can try visiting `about:config` and creating a string-valued preference called `ui.-moz-sidebar` with value e.g. `rgb(255,0,255)` to manually make the sidebar pink.  `ui.-moz-sidebartext` will influence the color of some of the text there. The list of full about:config prefs to play with (if you like) is at https://searchfox.org/mozilla-central/rev/8c6edfe25c094e032a27722ef30f69555f556bf8/widget/nsXPLookAndFeel.cpp#215 , and you can see which (if any) of those is being used for a particular piece of the UI by using the Browser Toolbox  ( https://firefox-source-docs.mozilla.org/devtools-user/browser_toolbox/index.html ) to inspect the Firefox UI and drill down to find the relevant CSS keyword.

Possibly better, though, would be to build your own theme with Firefox Color: https://color.firefox.com/
(In reply to Emilio Cobos Álvarez (:emilio) from comment #26)
> The right fix is making the `MagentaNeon` theme author specify stuff like `sidebar_text` and `sidebar_background` colors TBH....

Ah, right. So probably, the reporter used to use a theme that specified those colors (which is the "good" state that they're remembering), and other themes like MagentaNeon happen to not-specify these colors.

Here's one theme that does seem to set that sidebar background-color (to a dark blue color), as an example of this working properly, given a theme that sets the appropriate values:
https://addons.mozilla.org/en-US/firefox/addon/spirited-away-animated/

@littlergirl: if that^ theme successfully sets the sidebar color for you (as it does for me), then I think we're all good here and this is just a case where you picked a theme that happens to not-specify a color for that bit of UI. :) 

(In reply to littlergirl from comment #18)
> I tried the modified version of the CSS you suggested (as seen below) and adding them to my gtk.css file does nothing:

Sorry, the CSS that I had quoted there wasn't meant as a suggested-edit for you to do -- that was just me quoting the CSS that Firefox uses internally to style this component, as a reference.  I have no idea offhand what the correct gtk.css styles would be that you could use to influence these colors (just due to my own ignorance of gtk.css internals); but you can try visiting `about:config` and creating a string-valued preference called `ui.-moz-sidebar` with value e.g. `rgb(255,0,255)` to manually make the sidebar pink.  `ui.-moz-sidebartext` will influence the color of some of the text there. The list of full about:config prefs to play with (if you like) is at https://searchfox.org/mozilla-central/rev/8c6edfe25c094e032a27722ef30f69555f556bf8/widget/nsXPLookAndFeel.cpp#215 , and you can see which (if any) of those is being used for a particular piece of the UI by using the Browser Toolbox  ( https://firefox-source-docs.mozilla.org/devtools-user/browser_toolbox/index.html ) to inspect the Firefox UI and drill down to find the relevant CSS keyword.

Possibly better, though, would be to build your own theme with Firefox Color: https://color.firefox.com/

Back to Bug 1908200 Comment 27