Bug 1908225 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Due to the complex nature of the PWA Dialog CFR and the way that the check to determine whether to show the CFR is implemented, the implementation will be deferred to this bug. As a part of this ticket, implement the behaviour of `CfrToolsAction.TogglePwaShown` in `CfrToolsPreferencesMiddleware.kt` along with displaying it in the UI in `CfrTools.kt`. Don't forget to write tests for the Middleware in `CfrToolsPreferencesMiddlewareTest.kt` after implementation
Revision 1 by
on 
Due to the complex nature of the PWA Dialog CFR and the way that the check to determine whether to show the CFR is implemented, the implementation will be deferred to this bug. As a part of this ticket, implement the behaviour of `CfrToolsAction.TogglePwaShown` in `CfrToolsPreferencesMiddleware.kt` along with displaying it in the UI in `CfrTools.kt`. Don't forget to write tests for the Middleware in `CfrToolsPreferencesMiddlewareTest.kt` after implementation.

[Here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#1082-1098) is the searchfox for the logic as to when to show the PWA CFR
Revision 2 by
on 
Due to the complex nature of the PWA Dialog CFR and the way that the check to determine whether to show the CFR is implemented, the implementation will be deferred to this bug. As a part of this ticket, implement the behaviour of `CfrToolsAction.TogglePwaShown` in `CfrToolsPreferencesMiddleware.kt` along with displaying it in the UI in `CfrTools.kt`. Also, add this CFR to the CfrPreferencesRepository.CfrPreference enum and make the necessary changes to the CfrPreferencesRepository. Don't forget to write / update the tests for the middleware in `CfrToolsPreferencesMiddlewareTest.kt`, the store in `CfrToolsStoreTest.kt`, and the repository in `DefaultCfrPreferencesRepositoryTest.kt`, after implementation.

[Here](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt#1082-1098) is the searchfox for the logic as to when to show the PWA CFR

Back to Bug 1908225 Comment 0