(In reply to gene smith from comment #26) > From comment 19: > > > I have a suspicion that this has something to do with the code that was **added recently** to stash a copy of the message into Drafts with a fake IMAP ID, then download the actual message from the server and replace the local copy and fake IMAP ID with the copy and ID downloaded from the server. This is just a guess, though, I can't point to anything specific which proves it. It's just that this seems like the most recent significant change to this part of the code. > > This doesn't sound like something I've worked on regarding IMAP. Don't know what it means by imap ID (maybe UID) or how it can be "fake". I was referring to this: https://hg.mozilla.org/comm-central/rev/b7bb63ac09ccfc8635dad5a46a986caa679ae11c Though I could certainly be off-base. > From comment 25: > > > Using the add-on (semi-)reliably creates the IMAP folder corruption. The add-on puts a new message into the drafts folder, which is async, and then calls compact (old or new) on the folder, so those two operations likely run interleaved and cause the issue. Just a hypothesis, of course. > > May be better to just force an imap expunge of drafts so it doesn't directly cause a compact of mbox. Not sure if that's possible from addon code. This is a good idea, thanks. I've [implemented this in version 10.5.8 of Send Later](https://github.com/Extended-Thunder/send-later/commit/d39bf0d911cc27b06560691329931041fa33c8f4#diff-1136dfecf0ddcc00ab8a480f4c4bb3e3322133fd037e768132b7315132e08498L845) which I've just [put out as a beta release](https://github.com/Extended-Thunder/send-later/releases/tag/v10.5.8). However, it's important to note that this is just working around the corruption issue. As others have noted, Send Later isn't the only thing that causes the corruption, and so we really should get to the root cause of the corruption and fix it. Having said that **IMPORTANT NOTE** if you want to reproduce this issue using Send Later as described above, you need to use [version 10.5.2](https://addons.thunderbird.net/thunderbird/addon/send-later-3/versions/?page=1#version-10.5.2), because newer versions have workarounds for the corruption issue in them.
Bug 1909111 Comment 27 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to gene smith from comment #26) > From comment 19: > > > I have a suspicion that this has something to do with the code that was **added recently** to stash a copy of the message into Drafts with a fake IMAP ID, then download the actual message from the server and replace the local copy and fake IMAP ID with the copy and ID downloaded from the server. This is just a guess, though, I can't point to anything specific which proves it. It's just that this seems like the most recent significant change to this part of the code. > > This doesn't sound like something I've worked on regarding IMAP. Don't know what it means by imap ID (maybe UID) or how it can be "fake". I was referring to this: https://hg.mozilla.org/comm-central/rev/b7bb63ac09ccfc8635dad5a46a986caa679ae11c Though I could certainly be off-base. > From comment 25: > > > Using the add-on (semi-)reliably creates the IMAP folder corruption. The add-on puts a new message into the drafts folder, which is async, and then calls compact (old or new) on the folder, so those two operations likely run interleaved and cause the issue. Just a hypothesis, of course. > > May be better to just force an imap expunge of drafts so it doesn't directly cause a compact of mbox. Not sure if that's possible from addon code. This is a good idea, thanks. I've [implemented this in version 10.5.8 of Send Later](https://github.com/Extended-Thunder/send-later/commit/d39bf0d911cc27b06560691329931041fa33c8f4#diff-1136dfecf0ddcc00ab8a480f4c4bb3e3322133fd037e768132b7315132e08498L845) which I've just [put out as a beta release](https://github.com/Extended-Thunder/send-later/releases/tag/v10.5.8). However, it's important to note that this is just working around the corruption issue. As others have noted, Send Later isn't the only thing that causes the corruption, and so we really should get to the root cause of the corruption and fix it. Having said that **IMPORTANT NOTE** if you want to reproduce this issue using Send Later as described above, you need to use [version 10.5.1](https://addons.thunderbird.net/thunderbird/addon/send-later-3/versions/?page=1#version-10.5.1), because newer versions have workarounds for the corruption issue in them.