Bug 1909350 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I'm hitting the same issue, and been looking into it (not much else to do when you can't build!).

Essentially it looks like the Rust template for `glean-parser` was updated to include `LabeledMetricData` in version 14.3.0, which was released [about 18h ago](https://github.com/mozilla/glean_parser/releases/tag/v14.3.0) (https://github.com/mozilla/glean_parser/commit/d2462138204b9b828b6876ae4ccf49383fdeeaae is the specific commit). The latest publicly available version of the `glean` crate (60.3.0, which seems to also be the version [pinned in m-c](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/Cargo.toml#63), and that the crashreporter [uses](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/toolkit/crashreporter/client/app/Cargo.toml#15)) does not seem to export `LabeledMetricData`: https://docs.rs/glean/60.3.0/glean/?search=LabeledMetricData

So likely mach picked it up when it last checked whether its Python virtualenv was up to date, which caused it to start generating bogus Rust files. I'm assuming taskcluster builds have been unimpacted because there's a vendored copy of `glean-parser` in m-c that's pinned to 14.1.2: https://searchfox.org/mozilla-central/source/third_party/python/glean_parser

As a result, I'm changing the regressing bug to bug 1909244 (which introduced this change in `glean-parser`) and NI'ing :chutten as the author of that change.
I'm hitting the same issue, and been looking into it (not much else to do when you can't build!).

Essentially it looks like the Rust template for `glean-parser` was updated to include `LabeledMetricData` in version 14.3.0, which was released [about 18h ago](https://github.com/mozilla/glean_parser/releases/tag/v14.3.0) (https://github.com/mozilla/glean_parser/commit/d2462138204b9b828b6876ae4ccf49383fdeeaae is the specific commit). The latest publicly available version of the `glean` crate (60.3.0, which seems to also be the version [pinned in m-c](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/Cargo.toml#63), and that the crashreporter [uses](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/toolkit/crashreporter/client/app/Cargo.toml#15)) does not seem to export `LabeledMetricData`: https://docs.rs/glean/60.3.0/glean/?search=LabeledMetricData

So likely mach picked it up when it last checked whether its Python virtualenv was up to date, which caused it to start generating bogus Rust files. I'm assuming taskcluster builds have been unimpacted because there's a vendored copy of `glean-parser` in m-c that's pinned to 14.1.2: https://searchfox.org/mozilla-central/source/third_party/python/glean_parser (though that's very much a guess since I'm not familiar enough with all the ins and outs of Python vendoring in this context)

As a result, I'm changing the regressing bug to bug 1909244 (which introduced this change in `glean-parser`) and NI'ing :chutten as the author of that change.
I'm hitting the same issue, and been looking into it (not much else to do when you can't build!).

Essentially it looks like the Rust template for `glean-parser` was updated to include `LabeledMetricData` in version 14.3.0, which was released [about 18h ago](https://github.com/mozilla/glean_parser/releases/tag/v14.3.0) (https://github.com/mozilla/glean_parser/commit/d2462138204b9b828b6876ae4ccf49383fdeeaae is the specific commit). The latest publicly available version of the `glean` crate (60.3.0, which seems to also be the version [pinned in m-c](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/Cargo.toml#63), and that the crashreporter [uses](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/toolkit/crashreporter/client/app/Cargo.toml#15)) does not seem to export `LabeledMetricData`: https://docs.rs/glean/60.3.0/glean/?search=LabeledMetricData

So likely mach picked it up when it last checked whether its Python virtualenv was up to date, which caused it to start generating bogus Rust files. I'm assuming taskcluster builds have been unimpacted because there's a vendored copy of `glean-parser` in m-c that's pinned to 14.1.2: https://searchfox.org/mozilla-central/source/third_party/python/glean_parser (though that's very much a guess since I'm not familiar enough with all the ins and outs of Python vendoring in this context)

As a result, I'm changing the regressing bug to bug 1909244 (which introduced this change in `glean-parser`) and NI'ing :chutten as the author of that change.

Edit:  It looks like `LabeledMetricData` does exist in `glean`'s source tree, just not in a released version: https://github.com/mozilla/glean/blob/1ae14f5718c402ab5c4bc1993a5e985947564da2/glean-core/src/metrics/labeled.rs#L44
I'm hitting the same issue, and been looking into it.

Essentially it looks like the Rust template for `glean-parser` was updated to include `LabeledMetricData` in version 14.3.0, which was released [about 18h ago](https://github.com/mozilla/glean_parser/releases/tag/v14.3.0) (https://github.com/mozilla/glean_parser/commit/d2462138204b9b828b6876ae4ccf49383fdeeaae is the specific commit). The latest publicly available version of the `glean` crate (60.3.0, which seems to also be the version [pinned in m-c](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/Cargo.toml#63), and that the crashreporter [uses](https://searchfox.org/mozilla-central/rev/de46cd99a7d1634058b511a3f546a970763e5048/toolkit/crashreporter/client/app/Cargo.toml#15)) does not seem to export `LabeledMetricData`: https://docs.rs/glean/60.3.0/glean/?search=LabeledMetricData

So likely mach picked it up when it last checked whether its Python virtualenv was up to date, which caused it to start generating bogus Rust files. I'm assuming taskcluster builds have been unimpacted because there's a vendored copy of `glean-parser` in m-c that's pinned to 14.1.2: https://searchfox.org/mozilla-central/source/third_party/python/glean_parser (though that's very much a guess since I'm not familiar enough with all the ins and outs of Python vendoring in this context)

As a result, I'm changing the regressing bug to bug 1909244 (which introduced this change in `glean-parser`) and NI'ing :chutten as the author of that change.

Edit:  It looks like `LabeledMetricData` does exist in `glean`'s source tree, just not in a released version: https://github.com/mozilla/glean/blob/1ae14f5718c402ab5c4bc1993a5e985947564da2/glean-core/src/metrics/labeled.rs#L44

Back to Bug 1909350 Comment 2