It is most probably due to the missing `firefox-appdir` entry here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#2-5 Compare with the many other tests, where it is present: https://searchfox.org/mozilla-central/search?q=firefox-appdir+%3D+%22browser%22&path=toolkit&case=false®exp=false If I add that line to `unit_aus_update/xpcshell.toml`, then `app.update.langpack.enabled` is set for Firefox as well and the test fails like it fails for Thunderbird. For whatever reason, Thunderbird behaved differently and always loads its prefs, while Firefox loads them only if the `firefox-appdir = browser` line is present. I did not find anything related in the codebase. I think it is not fruitful to invest more time into this. My suggestion is to ask m-c- to set the pref here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#5 If I change that line to ``` prefs = ["app.update.staging.enabled=false", "app.update.langpack.enabled=false"] ``` then the test passes for Thunderbird.
Bug 1911887 Comment 12 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
It is most probably due to the missing `firefox-appdir` entry here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#2-5 Compare with the many other tests, where it is present: https://searchfox.org/mozilla-central/search?q=firefox-appdir+%3D+%22browser%22&path=toolkit&case=false®exp=false If I add that line to `unit_aus_update/xpcshell.toml`, then `app.update.langpack.enabled` is set for Firefox as well and the test fails like it fails for Thunderbird. For whatever reason, Thunderbird behaves differently and always loads its prefs, while Firefox loads them only if the `firefox-appdir = browser` line is present. I did not find anything related in the codebase. I think it is not fruitful to invest more time into this. My suggestion is to ask m-c- to set the pref here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#5 If I change that line to ``` prefs = ["app.update.staging.enabled=false", "app.update.langpack.enabled=false"] ``` then the test passes for Thunderbird.
It is most probably due to the missing `firefox-appdir` entry here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#2-5 Compare with the many other tests, where it is present: https://searchfox.org/mozilla-central/search?q=firefox-appdir+%3D+%22browser%22&path=toolkit&case=false®exp=false If I add that line to `unit_aus_update/xpcshell.toml`, then `app.update.langpack.enabled` is set for Firefox as well and the test fails like it fails for Thunderbird. For whatever reason, Thunderbird behaves differently in xpcshell tests and always loads its prefs, while Firefox loads them only if the `firefox-appdir = browser` line is present. I did not find anything related in the codebase. I think it is not fruitful to invest more time into this. My suggestion is to ask m-c- to set the pref here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#5 If I change that line to ``` prefs = ["app.update.staging.enabled=false", "app.update.langpack.enabled=false"] ``` then the test passes for Thunderbird.
It is most probably due to the missing `firefox-appdir` entry here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#2-5 Compare with the many other tests, where it is present: https://searchfox.org/mozilla-central/search?q=firefox-appdir+%3D+%22browser%22&path=toolkit&case=false®exp=false If I add that line to `unit_aus_update/xpcshell.toml`, then `app.update.langpack.enabled` is set for Firefox as well and the test fails like it fails for Thunderbird. For whatever reason, Thunderbird behaves differently in xpcshell tests and always loads its prefs, while Firefox loads them only if the `firefox-appdir = "browser"` line is present. I did not find anything related in the codebase. I think it is not fruitful to invest more time into this. My suggestion is to ask m-c- to set the pref here: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.toml#5 If I change that line to ``` prefs = ["app.update.staging.enabled=false", "app.update.langpack.enabled=false"] ``` then the test passes for Thunderbird.