I produce C-C TB patches from time to time and test them under linux on local PC. I am usinng Debian GNU/Linux. Since I updated the M-C portion of the code a few days ago, I noticed a very strange phenomena. It used to be (before the update), a block of text that shows the successful build was printed at the end of the build. (The following s is from a last year's build. Sorry, I don't keep the successful log from the last week handy.) I am using "make -k 6" by specifying the -k 6 in mozconfig. So there are 6 sub makes running, I think. ``` Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3' gmake[2]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3' gmake[1]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3' 14 compiler warnings present. Overall system resources - Wall time: 168s; CPU: 15%; Read bytes: 14775111680; Write bytes: 5257326592; Read time: 194641; Write time: 61017 Swap in/out (MB): 35.8125/603.55078125 ccache (direct) hit rate: 98.8%; (preprocessed) hit rate: 0.0%; miss rate: 1.2% To view resource usage of the build, run |mach resource-usage|. Your build was successful! To take your build for a test drive, run: |mach run| ``` Thes output was very useful to recognize the success of the build attempt. But since the local M-C tree update a few days ago, I do not see this message at all. Or rather I should say, I only see this from time to time. That is, often, I don't see the message lines at all and the last lines of the build are only like the following lines and the |mach build| finishes without clear indication of build success or failure. Strange. ``` gmake[4]: Nothing to be done for 'target-objects'. gmake[4]: Leaving directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/mediasniffer' gmake[4]: Entering directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/printingui/ipc' gmake[4]: Nothing to be done for 'target-objects'. gmake[4]: Leaving directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/printingui/ipc' gmake[4]: Entering directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/processtools' gmake[4]: Nothing to be done for 'target-objects'. ``` No success message at all. Now I realize this may be due to the fix in Bug 1906191. Since in my quest to run C-C TB under valgrind during mochitest and/or xpcshell test, I needed to make the timeout in various *.py files very long and I needed dump some values related to timeout when a timeout occurred to figure out whch timeout values may need more large value. My patches for this purpose did not apply to processhandler.py cleanly in a few places after the upgrade of M-C tree a few days ago. For example, near the following line, the patch failed to apply cleanly and I knew some changes were made to handle the processing of the output from make and other commands. https://searchfox.org/mozilla-central/source/testing/mozbase/mozprocess/mozprocess/processhandler.py#1104 So I suspect the change in Bug 1906191 causes an unwanted side-effect? But where have the success message lines gone then? Have they completely disappeared? To my surprise, they are scattered between the "Entering/Nothing to do/Leaving" lines (!!!) I am attaching the last part of the log printed on the console where I invoked |mach build|. The messages are nowhere to find at the end, but they are scattered between Entering directory/Nothing to be done /Leaving directory lines. I have attached the tail end of the last build log. Not useful at all. I have observed the strange stall mentioned in Bug 1906191 comment ７ myself under local Linux PC since early summer. So, if this stall is fixed by the patch there, that is great. However, I think ithe patch may have introduced other problems. For this particular issue of the ending summary text now shown, maybe the C-C TB's make file may be modified(?). I am not sure whether such rewrite is possible, though. In any case, the lack of the resource summary and the notification of success at the very of the log which I capture using "script" command is very annoying because I cannot immediately see whether the build failed or not. I wish it is fixed very soon. I wonder if anyone is seeing this on their own linux PC.
Bug 1916100 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I produce C-C TB patches from time to time and test them under linux on local PC. I am usinng Debian GNU/Linux. Since I updated the M-C portion of the code a few days ago, I noticed a very strange phenomena. It used to be (before the update), a block of text that shows the successful build was printed at the end of the build. (The following s is from a last year's build. Sorry, I don't keep the successful log from the last week handy.) I am using "make -j6" by specifying the -j6 in mozconfig. (sorry I mistyped 'k' the first time. It was 'j') So there are 6 sub makes running, I think. ``` Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3' gmake[2]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3' gmake[1]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3' 14 compiler warnings present. Overall system resources - Wall time: 168s; CPU: 15%; Read bytes: 14775111680; Write bytes: 5257326592; Read time: 194641; Write time: 61017 Swap in/out (MB): 35.8125/603.55078125 ccache (direct) hit rate: 98.8%; (preprocessed) hit rate: 0.0%; miss rate: 1.2% To view resource usage of the build, run |mach resource-usage|. Your build was successful! To take your build for a test drive, run: |mach run| ``` These output lines were very useful to recognize the success of the build attempt. But since the local M-C tree update a few days ago, I do not see this message at all. Or rather I should say, I only see this from time to time. That is, often, I don't see the message lines at all and the last lines of the build are only like the following lines and the |mach build| finishes without clear indication of build success or failure. Strange and very irritating. ``` gmake[4]: Nothing to be done for 'target-objects'. gmake[4]: Leaving directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/mediasniffer' gmake[4]: Entering directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/printingui/ipc' gmake[4]: Nothing to be done for 'target-objects'. gmake[4]: Leaving directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/printingui/ipc' gmake[4]: Entering directory '/NEW-SSD/ASAN-OBJ-DIR/objdir-tb3/toolkit/components/processtools' gmake[4]: Nothing to be done for 'target-objects'. ``` No success message at all. Now I realize this may be due to the fix in Bug 1906191. Since in my quest to run C-C TB under valgrind during mochitest and/or xpcshell test, I needed to make the timeout in various *.py files very long and I needed dump some values related to timeout when a timeout occurred to figure out which timeout values may need to be longer to run TB under valgrind to successfully execute mochitest or xpcshell-test.. My patches for this purpose did not apply to processhandler.py cleanly in a few places after the upgrade of M-C tree a few days ago. For example, near the following line, the patch failed to apply cleanly and I knew some changes were made to handle the processing of the output from make and other commands. https://searchfox.org/mozilla-central/source/testing/mozbase/mozprocess/mozprocess/processhandler.py#1104 So I suspect the change in Bug 1906191 causes an unwanted side-effect? But where have the success message lines gone then? Have they completely disappeared? To my surprise, they are scattered between the "Entering/Nothing to do/Leaving" lines (!!!) I am attaching the last part of the log printed on the console where I invoked |mach build|. The messages are nowhere to find at the end, but they are scattered between Entering directory/Nothing to be done /Leaving directory lines. I have attached the tail end of the last build log. The output at the end of the successful build is no longer printed at the end, and it is not useful at all. I have observed the strange stall mentioned in Bug 1906191 comment ７ myself under local Linux PC since early summer. So, if this stall is fixed by the patch there, that is great. However, I think the patch may have introduced other problems. For this particular issue of the ending summary text now shown, maybe the C-C TB's make file may be modified(?). I am not sure whether such rewrite is possible, though. In any case, the lack of the resource summary and the notification of success at the very end of the log which I capture using "script" command is very annoying because I cannot immediately see whether the build failed or not. I wish it is fixed very soon. I wonder if anyone is seeing this on their own linux PC. EDIT: Fixed some typos and clarified a few places.