> This bug is a regression by the new nav bar
Don't know the technicalities of how Gecko handles this but seems to me like the green bar is the height of the toolbar sent from Fenix through the `setDynamicToolbarMaxHeight` API. And this will differ between
- if the keyboard is opened - we only show the address bar, say 50px
- if the keyboard is closed - we show both the address bar and the navbar, say 50px + 50px
For this situations I think we should update the value through `setDynamicToolbarMaxHeight` but given the report here I'm curious why it is a problem? What are the implications? How often would users see a bug from this and then of course what is the proposed approach for fixing this?
Do share a similar concern to Chris so answers to the above questions would help know whether this issue should block the navbar release or not.
Bug 1916154 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> This bug is a regression by the new nav bar
Don't know the technicalities of how Gecko handles this but seems to me like the green bar is the height of the toolbar sent from Fenix through the `setDynamicToolbarMaxHeight` API. And this will differ between
- if the keyboard is opened - we only show the address bar, say 50px
- if the keyboard is closed - we show both the address bar and the navbar, say 50px + 50px
For this situations I think we should update the value through `setDynamicToolbarMaxHeight` but given the report here I'm curious why it is a problem? What are the implications? How often would users see a bug from this and then of course what is the proposed approach for fixing this?
I think Chris' concern (which I do share) was whether this should block the navbar release or not, hoping that answers to the above questions would help better understand this.