(In reply to Sarah Clements [:sclements] from comment #6) > That's a good point about bug 1899598 and what the plan is. Sam, perhaps you can speak to what the latest is with how you're approaching the styling for the navbar/title bar? Yeah. So normally the tabstrip is visually a part of the titlebar. It share's the same color as the menubar if that's visible, and when it and the titlebar are hidden (tabs-in-titlebar) it funtionally *is* the titlebar. For the vertical tabs case, this will get hidden, so the nav-bar becomes the titlebar essntially. All the CSS rules and behavior that would have applied explicitly to the #TabsToolbar become "the first toolbar sibling to the menubar". To do this, I'm proposing to move the `#nav-bar` element into the `#titlebar` element so it is a sibling of ``#TabsToolbar`. It will have the same `titlebar-items.inc.xhtml` include as `#TabsToolbar` which will get un-hidden as necessary. Does that answer your question? I can update my WIP if it helps.
Bug 1916762 Comment 8 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Sarah Clements [:sclements] from comment #6) > That's a good point about bug 1899598 and what the plan is. Sam, perhaps you can speak to what the latest is with how you're approaching the styling for the navbar/title bar? Yeah. So normally the tabstrip is visually a part of the titlebar. It shares the same color as the menubar if that's visible, and when it and the titlebar are hidden (tabs-in-titlebar) it funtionally *is* the titlebar. For the vertical tabs case, this too will get hidden, so the nav-bar becomes the titlebar essntially. All the CSS rules and behavior that would have applied explicitly to the #TabsToolbar become "the first toolbar sibling to the menubar". To do this, I'm proposing to move the `#nav-bar` element into the `#titlebar` element so it is a sibling of ``#TabsToolbar`. It will have the same `titlebar-items.inc.xhtml` include as `#TabsToolbar` which will get un-hidden as necessary. Does that answer your question? I can update my WIP if it helps.
(In reply to Sarah Clements [:sclements] from comment #6) > That's a good point about bug 1899598 and what the plan is. Sam, perhaps you can speak to what the latest is with how you're approaching the styling for the navbar/title bar? Yeah. So normally the tabstrip is visually a part of the titlebar. It shares the same color as the menubar if that's visible, and when it and the titlebar are hidden (tabs-in-titlebar) it funtionally *is* the titlebar. For the vertical tabs case, this too will get hidden, so the nav-bar becomes the titlebar essntially. All the CSS rules and behavior that would have applied explicitly to the #TabsToolbar become "the first toolbar sibling to the menubar". To do this, I'm proposing to move the `#nav-bar` element into the `#titlebar` element so it is a sibling of `#TabsToolbar`. It will have the same `titlebar-items.inc.xhtml` include as `#TabsToolbar` which will get un-hidden as necessary. Does that answer your question? I can update my WIP if it helps.