When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expect Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, if I replace `max-height` with `height`, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): `MOZASSERT(aspectRatioUsage == AspectRatioUsage::None)` in nsIFrame.cpp.
Bug 1918794 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expect Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, if I replace `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): `MOZASSERT(aspectRatioUsage == AspectRatioUsage::None)` in nsIFrame.cpp.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expect Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, if I replace `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): `MOZ_ASSERT(aspectRatioUsage == AspectRatioUsage::None)` in nsIFrame.cpp.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expect Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, if I replace `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): ```MOZ_ASSERT(aspectRatioUsage == AspectRatioUsage::None)``` in nsIFrame.cpp.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expect Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, if I replace `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): > `MOZ_ASSERT(aspectRatioUsage == AspectRatioUsage::None)` in ``nsIFrame::ComputeSize()`.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expect Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, when I replaced `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): > `MOZ_ASSERT(aspectRatioUsage == AspectRatioUsage::None)` in ``nsIFrame::ComputeSize()`.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expected Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, when I replaced `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): > `MOZ_ASSERT(aspectRatioUsage == AspectRatioUsage::None)` in ``nsIFrame::ComputeSize()`.
When checking if we need to pass the containing block size to a grid item which is a subgrid (for Bug 1865438), I noticed we have a different result from Blink and Webkit when using subgrid and aspect-ratio together. See the attached testcase. * Expected Result: We should see a 80px * 100px green rect, with a blue small rect at the bottom right corner (just as that result in Blink and WebKit). * Actual Result: We render a 80px * 80px green rect, with a blue small rect at the bottom right corner. Also, when I replaced `max-height` with `height` in the testcase I attached, I hit [this assertion](https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/layout/generic/nsIFrame.cpp#6644): > `MOZ_ASSERT(aspectRatioUsage == AspectRatioUsage::None)` in `nsIFrame::ComputeSize()`.