Bug 1919230 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Hi Clemens Weiß, thanks for submitting this bug!

I do believe that this is a genuine defect in which we are respecting no-translate attributes with regard to a node's text content, but not with regard to its other translatable attributes. 

I'll write a patch to fix this and add an automated test case to cover this behavior. 

Thanks for taking the time to create an example HTML document. That was super helpful!
Hi Clemens Weiß, thanks for submitting this bug!

I do believe that this is a genuine defect in which we are respecting no-translate attributes with regard to a node's text content, but not with regard to its other translatable attributes. 

I'll write a patch to fix this and add an automated test case to cover this behavior. 

Thanks for taking the time to create an example HTML document. That was super helpful!

---

(In reply to Clemens Weiß from comment #2)
> Also the "Submit" button gets translated to "Untermit", which makes no sense. "Absenden" or "Abschicken" would be correct.

Unfortunately this is beyond the scope of this patch as it relates to the quality of the output from the English-to-German machine-learning model. 

We do hope to continue to iterate on the quality of our models as well as release newly trained language models. Any issues related to model translation quality should be reported here. We appreciate the feedback!

https://github.com/mozilla/firefox-translations-training

Back to Bug 1919230 Comment 3