Bug 1920732 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Same wa(In reply to Paul Zühlcke [:pbz] from comment #7)
> Same as Tom, we must not send the data and we should log a warning.
> How do I update the event in m-c to not collect when on Android? Maybe we should flip that logic and only collect on Desktop.

Same way you guard any code in m-c against being run in Android: `#ifndef MOZ_WIDGET_ANDROID`

Since you've both confirmed this is your preference, I'll file a bug and put up a patch to wrap the two submit calls in that. Data will still be recorded (for now. We'll see if we can be clever in the design for the general solution to this bug) but it'll never leave the client.
Revision 1 by
on 
(In reply to Paul Zühlcke [:pbz] from comment #7)
> Same as Tom, we must not send the data and we should log a warning.
> How do I update the event in m-c to not collect when on Android? Maybe we should flip that logic and only collect on Desktop.

Same way you guard any code in m-c against being run in Android: `#ifndef MOZ_WIDGET_ANDROID`

Since you've both confirmed this is your preference, I'll file a bug and put up a patch to wrap the two submit calls in that. Data will still be recorded (for now. We'll see if we can be clever in the design for the general solution to this bug) but it'll never leave the client.
Revision 2 by
on 
(In reply to Paul Zühlcke [:pbz] from comment #7)
> Same as Tom, we must not send the data and we should log a warning.
> How do I update the event in m-c to not collect when on Android? Maybe we should flip that logic and only collect on Desktop.

Same way you guard any code in m-c against being run in Android: `#ifndef MOZ_WIDGET_ANDROID`

Since you've both confirmed this is your preference, I'll file a bug and put up a patch to wrap the two submit calls in that. Data will still be recorded (for now. We'll see if we can be clever in the design for the general solution to this bug) but it'll never leave the client.

(Not sure if gecko can discern whether it's being built as a Firefox Desktop app or not. If so, I'd guess that'd probably be a runtime thing instead of compile-time.)

Back to Bug 1920732 Comment 8