In the profiler frontend, we have a very naive way to find the favicons, which is just appending `favicon.ico` to a `origin` and then hope that it will be present in the profiler. But that's not always the case. Also whenever we are opening a profile we always ping the favicon urls to get the images, which is not ideal. Inside Firefox, we already get the favicon, so we should be able to either query the engine to get this information, or add an profiler call while we are extracting this information to save this as well. This will also help the profiler tab selector that I'm working on implementing, as we will always have proper favicons, and will not have missing ones when the icon is not in the usual `/favicon.ico` url.
Bug 1921778 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
In the profiler frontend, we have a very naive way to find the favicons, which is just appending `favicon.ico` to a `origin` and then hope that it will be present in the server. But that's not always the case. Also whenever we are opening a profile we always ping the favicon urls to get the images, which is not ideal. Inside Firefox, we already get the favicon, so we should be able to either query the engine to get this information, or add an profiler call while we are extracting this information to save this as well. This will also help the profiler tab selector that I'm working on implementing, as we will always have proper favicons, and will not have missing ones when the icon is not in the usual `/favicon.ico` url.