In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally. Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? (Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term rather than leaving this patch in pending a fix for bug 1925635. And then maybe we can (re)land this bug's patches together with bug 1925635 next week [or when we're ready] for the 134 nightly cycle?)
Bug 1923251 Comment 13 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally, and they're currently broken in Nightly as a result (per bug 1925606, bug 1926087). Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? (Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term rather than leaving this patch in pending a fix for bug 1925635. And then maybe we can (re)land this bug's patches together with bug 1925635 next week [or when we're ready] for the 134 nightly cycle?)
In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally, and they're currently broken in Nightly as a result (per bug 1925606, bug 1926087). Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? (Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term, rather than the alternative approach of leaving this patch in & trying to quickly land a fix for bug 1925635. And then maybe we can (re)land this bug's patches together with bug 1925635 next week [or when we're ready] for the 134 nightly cycle?)
In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally, and they're currently broken in Nightly as a result (per bug 1925606, bug 1926087). Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? (Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term, rather than the alternative approach of leaving this patch in & trying to quickly land a fix for bug 1925635. And then maybe we can (re)land this bug's patches together with a fix for bug 1925635 next week [or when we're ready] for the 134 nightly cycle?)
In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally, and they're currently broken in Nightly as a result (per bug 1925606, bug 1926087). Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? (Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term, rather than the alternative approach of leaving this patch in & trying to quickly land a fix for bug 1925635. And if we do backout here, I'm imagining we'd re-land this bug's patches together with a fix for bug 1925635 next week [or when we're ready] for the 134 nightly cycle?)
In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally, and they're currently broken in Nightly as a result (per bug 1925606, bug 1926087). Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? (Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term, rather than the alternative approach of leaving this patch in & trying to quickly land a fix for bug 1925635. And if we do backout here, I'm imagining we'd re-land this bug's patches together with a fix for bug 1925635 next week [or when we're ready] as part of the 134 nightly cycle?)
In particular: the trailing `<br>` line-break here (described in comment 0) turned out to have actually been functional in many real-world cases, in that it served as a hackaround to prevent us from hitting bug 1925635. Quick STR to demonstrate that: (1) Open the "semi-reference-case" from bug 1925635: https://bugzilla.mozilla.org/attachment.cgi?id=9432321 (2) Click after "def" and press Ctrl+backspace (3) Type "ggg" and notice that the space was preserved (hooray) -- however if you have devtools open, you might notice that the `br` disappeared... (4) Ctrl+backspace to delete "ggg" (5) Type "hhh" ACTUAL RESULTS: In Nightlies that include this bug's patch (after comment 9 here), you end up seeing "abchhh" with no space. EXPECTED RESULTS: You should see "abc hhh" at the end of step 5, just like you saw "abc ggg" at the end of step 3. Various web properties (Gmail, Google Docs comments, maybe Fastmail) seem to have been relying on that, whether intentionally or unintentionally, and they're currently broken in Nightly as a result (per bug 1925606, bug 1926087). Until we're confident in a fix for bug 1925635, we may want to backout the change here -- masayuki, does that sound OK to you? Note that it's RC week -- merge day is next Monday -- so we might want to err on the side of caution and opt for a backout for the short term, rather than the alternative approach of leaving this patch in & trying to quickly land a fix for bug 1925635. And if we do backout here, I'm imagining we'd re-land this bug's patches together with a fix for bug 1925635 next week [or when we're ready] as part of the 134 nightly cycle - how does that sound?