Bug 1924918 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Wayne Mery (:wsmwk) from bug 1923526 comment 23)
> How will expunge on shutdown factor in?  Is it likely to trigger compact?

And there it is, the complicating factor I haven't thought about.

Expunge on shutdown triggers a compaction of the inbox (and presumably we want this). The compaction does happen earlier in shutdown than the patch here would prevent, but I'm unclear if shutdown waits for it to finish before moving to the next phase. I did a simple test and it appears that compaction _was_ completed.

Either way, if it lasts for over a minute the shutdown terminator will kill it and we'll continue to get the crash reports this bug was trying to prevent.
(In reply to Wayne Mery (:wsmwk) from bug 1923526 comment 23)
> How will expunge on shutdown factor in?  Is it likely to trigger compact?

And there it is, the complicating factor I haven't thought about.

Expunge on shutdown triggers a compaction of the inbox (and presumably we want this). The compaction does happen earlier in shutdown than the patch here would prevent, but I'm unclear if shutdown waits for it to finish before moving to the next phase. I did a simple test and it appears that compaction _was_ completed.

Either way, if it lasts for over a minute [the shutdown terminator](https://searchfox.org/mozilla-central/source/toolkit/components/terminator/nsTerminator.cpp) will kill it and we'll continue to get the crash reports this bug was trying to prevent.

Back to Bug 1924918 Comment 7