Bugzilla

(In reply to Daniel Holbert [:dholbert] from comment #5)
> Created attachment 9432321 [details]
> semi-reference-case for testcase 1
> [...]
> (However: in this reference case, we delete that `<br>` as soon as you start typing new characters into the textfield, so it's not a persistent fix here.  Maybe gmail had a hackaround that made it persist somehow -- whether intentionally or unintentionally -- not sure.)

Aha! This "we delete that `<br>`" behavior seems to be a recent behavior-change, I think from bug 1925606. So that's why we're starting to notice this issue a bit more on real-world web properties.

It sounds like that was an intended behavior-change, based on the part-2 commit message over there ("Make `HTMLEditor` clean up unnecessary padding line breaks when deleting something immediately before it").  But I suspect we didn't realize that these line breaks had a meaningful purpose in some cases, as they did in e.g. Gmail here.

(In reply to Daniel Holbert [:dholbert] from comment #5)
> Created attachment 9432321 [details]
> semi-reference-case for testcase 1
> [...]
> (However: in this reference case, we delete that `<br>` as soon as you start typing new characters into the textfield, so it's not a persistent fix here.  Maybe gmail had a hackaround that made it persist somehow -- whether intentionally or unintentionally -- not sure.)

Aha! This "we delete that `<br>`" behavior seems to be a recent behavior-change, I think from bug 1925606. So that's why we're starting to notice this issue a bit more on real-world web properties.

It sounds like that was an intended behavior-change, based on the part-2 commit message over there ("Make `HTMLEditor` clean up unnecessary padding line breaks when deleting something immediately before it").  But I suspect we didn't realize that these line breaks had a useful benefit in some cases, as they did in e.g. Gmail here.

(In reply to Daniel Holbert [:dholbert] from comment #5)
> Created attachment 9432321 [details]
> semi-reference-case for testcase 1
> [...]
> (However: in this reference case, we delete that `<br>` as soon as you start typing new characters into the textfield, so it's not a persistent fix here.  Maybe gmail had a hackaround that made it persist somehow -- whether intentionally or unintentionally -- not sure.)

Aha! This "we delete that `<br>`" behavior seems to be a recent behavior-change, ~I think from bug 1925606~ [EDIT: copypaste typo -- I meant "I think from bug 1923251".] So that's why we're starting to notice this issue a bit more on real-world web properties.

It sounds like that was an intended behavior-change, based on the part-2 commit message over there ("Make `HTMLEditor` clean up unnecessary padding line breaks when deleting something immediately before it").  But I suspect we didn't realize that these line breaks had a useful benefit in some cases, as they did in e.g. Gmail here.