(In reply to Sarah Clements [:sclements] from comment #14) > Will and I talked about this on slack and he gave me some more context. It sounds like there was a request years ago to allow this svg context-fill feature enabled for (regular - non-Mozilla-owned) extension icons, and the answer was "no" Yup, see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1388193 maybe elsewhere. > Since this was many years ago, it'd be great to find out if this decision can be revisited and if not for it to be clearly documented here (and for me to pass on to my PM). The decision still stands; this is a non-standard feature that we're using as a hackaround until we have cycles to implement the standardized replacement (in bug 1812163, on our radar but not a high-priority at the moment). Once we've got the standardized replacement implemented, we'd like to rapidly switch over all usages of context-fill/context-paint in our frontend icons to use the new thing, and then remove support for the current hacky context-fill/context-paint solution. If there are arbitrary 3rd-party extensions using & depending on this feature, then we probably won't be able to remove support, and we'll be doomed to supporting this as a legacy feature forever. We do have a way to opt-in extensions to be able to use this: see https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/layout/svg/SVGContextPaint.cpp#78-86 It looks like that should Just Work if we recognize the extension as being "mozilla-owned" per https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/toolkit/components/extensions/Extension.sys.mjs#296-305 . So the most direct fix here is to be sure your Sidebar extension falls into that category, I think.
Bug 1925701 Comment 15 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Sarah Clements [:sclements] from comment #14) > Will and I talked about this on slack and he gave me some more context. It sounds like there was a request years ago to allow this svg context-fill feature enabled for (regular - non-Mozilla-owned) extension icons, and the answer was "no" Yup, see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1388193 and maybe/probably other bugs where this was proposed & wontfix'ed. > Since this was many years ago, it'd be great to find out if this decision can be revisited and if not for it to be clearly documented here (and for me to pass on to my PM). The decision still stands; this is a non-standard feature that we're using as a hackaround until we have cycles to implement the standardized replacement (in bug 1812163, on our radar but not a high-priority at the moment). Once we've got the standardized replacement implemented, we'd like to rapidly switch over all usages of context-fill/context-paint in our frontend icons to use the new thing, and then remove support for the current hacky context-fill/context-paint solution. If there are arbitrary 3rd-party extensions using & depending on this feature, then we probably won't be able to remove support, and we'll be doomed to supporting this as a legacy feature forever. We do have a way to opt-in extensions to be able to use this: see https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/layout/svg/SVGContextPaint.cpp#78-86 It looks like that should Just Work if we recognize the extension as being "mozilla-owned" per https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/toolkit/components/extensions/Extension.sys.mjs#296-305 . So the most direct fix here is to be sure your Sidebar extension falls into that category, I think.
(In reply to Sarah Clements [:sclements] from comment #14) > Will and I talked about this on slack and he gave me some more context. It sounds like there was a request years ago to allow this svg context-fill feature enabled for (regular - non-Mozilla-owned) extension icons, and the answer was "no" Yup, see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1388193 and maybe/probably other bugs where this was proposed & wontfix'ed. > Since this was many years ago, it'd be great to find out if this decision can be revisited and if not for it to be clearly documented here (and for me to pass on to my PM). The decision still stands; this is a non-standard feature that we're using as a hackaround until we have cycles to implement the standardized replacement (in bug 1812163, on our radar but not a high-priority at the moment). Once we've got the standardized replacement implemented, we'd like to rapidly switch over all usages of context-fill/context-paint in our frontend icons to use the new thing, and then remove support for the current hacky context-fill/context-paint solution. If there are arbitrary 3rd-party extensions using & depending on this feature, then we could ask them nicely to remove/modernize their usages but likely many of them wouldn't, and hence they may break if we removed support, and we'll be doomed to supporting this as a legacy feature forever. We do have a way to opt-in extensions to be able to use this: see https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/layout/svg/SVGContextPaint.cpp#78-86 It looks like that should Just Work if we recognize the extension as being "mozilla-owned" per https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/toolkit/components/extensions/Extension.sys.mjs#296-305 . So the most direct fix here is to be sure your Sidebar extension falls into that category, I think.
(In reply to Sarah Clements [:sclements] from comment #14) > Will and I talked about this on slack and he gave me some more context. It sounds like there was a request years ago to allow this svg context-fill feature enabled for (regular - non-Mozilla-owned) extension icons, and the answer was "no" Yup, see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1388193 and maybe/probably other bugs where this was proposed & wontfix'ed. > Since this was many years ago, it'd be great to find out if this decision can be revisited and if not for it to be clearly documented here (and for me to pass on to my PM). The decision still stands; this is a non-standard feature that we're using as a hackaround until we have cycles to implement the standardized replacement (in bug 1812163, on our radar but not a high-priority at the moment). Once we've got the standardized replacement implemented, we'd like to rapidly switch over all usages of context-fill/context-paint in our frontend icons to use the new thing, and then remove support for the current hacky context-fill/context-paint solution. If there are arbitrary 3rd-party extensions using & depending on this feature, then we could ask them nicely to remove/modernize their usages but likely many of them wouldn't, and hence they may break if we removed support, and we'll be doomed to supporting this as a legacy feature forever. We do have a way to opt-in extensions to be able to use this, though, if they're under our control (so we're confident that we'll be able to rip out the context-fill/context-paint usage in the future). See https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/layout/svg/SVGContextPaint.cpp#78-86 It looks like that should Just Work if we recognize the extension as being "mozilla-owned" per https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/toolkit/components/extensions/Extension.sys.mjs#296-305 . So the most direct fix here is to be sure your Sidebar extension falls into that category, I think.
(In reply to Sarah Clements [:sclements] from comment #14) > Will and I talked about this on slack and he gave me some more context. It sounds like there was a request years ago to allow this svg context-fill feature enabled for (regular - non-Mozilla-owned) extension icons, and the answer was "no" Yup, see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1388193 and maybe/probably other bugs where this was proposed & wontfix'ed. > Since this was many years ago, it'd be great to find out if this decision can be revisited and if not for it to be clearly documented here (and for me to pass on to my PM). The decision still stands; this is a non-standard feature that we're using as a hackaround until we have cycles to implement the standardized replacement (in bug 1812163, on our radar but not a high-priority at the moment). Once we've got the standardized replacement implemented, we'd like to rapidly switch over all usages of context-fill/context-paint in our frontend icons to use the new thing, and then remove support for the current hacky context-fill/context-paint solution. If there are arbitrary 3rd-party extensions using & depending on this feature, then we could ask them nicely to remove/modernize their usages but likely many of them wouldn't, and hence they may break if we removed support, and we'll be doomed to supporting this as a legacy feature forever. We do have a way to opt-in extensions to be able to use this, though, if they're under our control (so we're confident that we'll be able to rip out the context-fill/context-paint usage in the future). See https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/layout/svg/SVGContextPaint.cpp#78-86 It looks like that should already Just Work for any extension that we recognize as being "mozilla-owned" per https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/toolkit/components/extensions/Extension.sys.mjs#296-305 . So the most direct fix here is to be sure your Sidebar extension falls into that category, I think.