Bug 1928682 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Adding on to the findings above:

I am aware that we use a weight with the menu redesign button, along with the other action buttons to the right of the toolbar - The 3 dot menu becomes a part of the `ActionContainer` to the right of the toolbar and we don't show the original menu button. However, it seems that the old menu button is positioned in xml and to the right of the `ActionContainer` in the toolbar [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#148-155)]. This leads me to believe that the issue lies in ActionContainer and how that is positioned on screen rotation / screen load [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#136-144)].

Some further questions I have that may help with further investigation is when / how do we determine the position of the `ActionContainer` and when / how do we determine the position / size of the toolbar.
Adding on to the findings above:

I am aware that we use a weight with the menu redesign button, along with the other action buttons to the right of the toolbar - The 3 dot menu becomes a part of the `ActionContainer` to the right of the toolbar and we don't show the original menu button. The weight determines the position of the different action buttons within the `ActionContainer`. However, it seems that the old menu button is positioned in xml and to the right of the `ActionContainer` in the toolbar [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#148-155)]. This leads me to believe that the issue lies in ActionContainer and how that is positioned on screen rotation / screen load [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#136-144)].

Some further questions I have that may help with further investigation is when / how do we determine the position of the `ActionContainer` and when / how do we determine the position / size of the toolbar.
Adding on to the findings above:

I am aware that we use a weight with the menu redesign button, along with the other action buttons to the right of the toolbar - The 3 dot menu becomes a part of the `ActionContainer` to the right of the toolbar and we don't show the original menu button. The weight determines the position of the different action buttons within the `ActionContainer`. However, it seems that the old menu button is positioned in xml and to the right of the `ActionContainer` in the toolbar [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#148-155)]. This leads me to believe that the issue lies in ActionContainer and how that is positioned on screen rotation / screen load [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#136-144)]. Note that there is an `ActionContainer` for the Page Actions (refresh, reader mode, etc... in new toolbar) and an `ActionContainer` for the Browser Actions (new tab icon, tabs tray icon, etc... on new toolbar with tab strip disabled). Since the refresh icon also appears to be in the wrong position in the bug, I think both of these ActionContainer instances have bugs.

Some further questions I have that may help with further investigation is when / how do we determine the position of the `ActionContainer` and when / how do we determine the position / size of the toolbar.
Adding on to the findings above:

I am aware that we use a weight with the menu redesign button, along with the other action buttons to the right of the toolbar - The 3 dot menu becomes a part of the `ActionContainer` to the right of the toolbar and we don't show the original menu button. The weight determines the position of the different action buttons within the `ActionContainer`. However, it seems that the old menu button is positioned in xml and to the right of the `ActionContainer` in the toolbar [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#148-155)]. This leads me to believe that the issue lies in ActionContainer and how that is positioned on screen rotation / screen load [[sf](https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/mobile/android/android-components/components/browser/toolbar/src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml#136-144)]. Note that there is an `ActionContainer` for the Page Actions (refresh, reader mode, etc... in new toolbar) and an `ActionContainer` for the Browser Actions (new tab icon, tabs tray icon, etc... on new toolbar with tab strip disabled). Since the refresh icon also appears to be in the wrong position in the videos, I think both of these ActionContainer instances have bugs.

Some further questions I have that may help with further investigation is when / how do we determine the position of the `ActionContainer` and when / how do we determine the position / size of the toolbar.

Back to Bug 1928682 Comment 6