Bug 1928801 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Could you please check this test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between creation of new transition and the sending the time to the compositor.

If we drop them, we may regress these tests I think.
Could you please check the test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between creation of new transition and the sending the time to the compositor.

If we drop them, we may regress these tests I think.
Could you please check the test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between creation of new transition and the sending the time to the compositor.

If we drop them, we may regress these tests I think.

(I just saw Emilio's link, and those patches make these tests failed indeed)
Could you please check the test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between creation of new transition and the sending the time to the compositor, e.g. busy main thread.

If we drop them, we may regress these tests I think.

(I just saw Emilio's link, and those patches make these tests failed indeed)
Could you please check the test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between the creation of new transition and the timing of sending the transition to the compositor, e.g. busy main thread.

If we drop them, we may regress these tests I think.

(I just saw Emilio's link, and those patches make these tests failed indeed)
Could you please check the test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between the creation of new transition and the timing of sending the transition to the compositor, e.g. busy main thread.

If we drop them, we may regress these tests and their original bug I think.

(I just saw Emilio's link, and those patches make these tests failed indeed)
Could you please check the test:
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_on_busy_frame.html
and
https://searchfox.org/mozilla-central/source/layout/style/test/test_transitions_replacement_with_setKeyframes.html
?

Brian added this implementation to fix the issue if there is a time gap between the creation of new transition and the timing of sending the transition to the compositor, e.g. busy main thread.

If we drop them, we may regress these tests and their original bugs I think.

(I just saw Emilio's link, and those patches make these tests failed indeed)

Back to Bug 1928801 Comment 17