(In reply to James Teh [:Jamie] from comment #5) > 1. Why do you think escape should return focus to the address bar? Can you explain the rationale here? > 2. In the majority of cases, escape dismisses a pop-up. From what I can tell, when you focus the unified search button, the address bar is always collapsed, so no pop-up is open and this doesn't apply. The dedicated search button is part of the urlbar. When I search something and select a suggestion with `Tab`, I can remove that selection by pressing `Esc`. The dedicated search button is in the `Tab` order of the search suggestion menu, therefore I expect I can remove the focus back to the urlbar when pressing `Esc` if it had previously focus. Note that this seems to have been implemented now. (Not sure which patch/bug). Pressing `Esc` on the dedicated search button returns focus to the urlbar. > 3. After bug 1086524, pressing escape on the address bar focuses the document. This is consistent with other browsers. I personally don't entirely follow the logic for this - yes, it's an input, but it's not a pop-up - but I guess it makes some sense if you think of the address bar as a modal with regard to how keyboard users interact with it. I focus the Adress bar by pressing `Ctrl + L`. Having some way (`Esc`) to return back to the document somehow feels natural to me too. > 4. Pressing escape on toolbar buttons in other browsers does nothing. I find that a bit inconsistent and I don't think we need to follow their example. I feel like this is not a design decision, but a current oversight in the UX for keyboard users that might get fixed by other browsers in the future too. > 5. Given that there's no established convention here, having escape do something when focused on a toolbar button isn't going to hurt anyone. However, this would be an enhancement, not a defect. I agree. > 6. I don't think it makes sense for escape on any toolbar button to focus the address bar. For example, I can't logically explain why pressing escape on the Bookmark button should focus the address bar. I agree. Address bar was mostly for the dedicated search bar. For other parts in the URL it probably makes sense to focus the document as well (e.g. from the search bar / back button, and maybe even other items within the urlbar. > 7. Having escape focus the document would be consistent with (3). 👍, haven't read that before writing (6). I fully agree.
Bug 1931920 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to James Teh [:Jamie] from comment #5) > 1. Why do you think escape should return focus to the address bar? Can you explain the rationale here? > 2. In the majority of cases, escape dismisses a pop-up. From what I can tell, when you focus the unified search button, the address bar is always collapsed, so no pop-up is open and this doesn't apply. The dedicated search button is part of the urlbar. When I search something and select a suggestion with `Tab`, I can remove that selection by pressing `Esc`. The dedicated search button is in the `Tab` order of the search suggestion menu, therefore I expect I can remove the focus back to the urlbar when pressing `Esc` if it had previously focus. Note that this seems to have been implemented now. (Not sure which patch/bug). Pressing `Esc` on the dedicated search button returns focus to the urlbar. > 3. After bug 1086524, pressing escape on the address bar focuses the document. This is consistent with other browsers. I personally don't entirely follow the logic for this - yes, it's an input, but it's not a pop-up - but I guess it makes some sense if you think of the address bar as a modal with regard to how keyboard users interact with it. I focus the Adress bar by pressing `Ctrl + L`. Having some way (`Esc`) to return back to the document somehow feels natural to me too. > 4. Pressing escape on toolbar buttons in other browsers does nothing. I find that a bit inconsistent and I don't think we need to follow their example. I feel like this is not a design decision, but a current oversight in the UX for keyboard users that might get fixed by other browsers in the future too. > 5. Given that there's no established convention here, having escape do something when focused on a toolbar button isn't going to hurt anyone. However, this would be an enhancement, not a defect. I agree. > 6. I don't think it makes sense for escape on any toolbar button to focus the address bar. For example, I can't logically explain why pressing escape on the Bookmark button should focus the address bar. I agree. This Bug was initially for the dedicated search button. For other parts in the URL it probably makes sense to focus the document as well (e.g. from the search bar / back button, and maybe even other items within the urlbar. > 7. Having escape focus the document would be consistent with (3). 👍, haven't read that before writing (6). I fully agree.
(In reply to James Teh [:Jamie] from comment #5) > 1. Why do you think escape should return focus to the address bar? Can you explain the rationale here? > 2. In the majority of cases, escape dismisses a pop-up. From what I can tell, when you focus the unified search button, the address bar is always collapsed, so no pop-up is open and this doesn't apply. The dedicated search button is part of the urlbar. When I enter text to search something and select a suggestion with `Tab`, I can remove that selection by pressing `Esc`. The dedicated search button is in the `Tab` order of the search suggestion menu, therefore I expect I can remove the focus back to the urlbar when pressing `Esc` if it had previously focus. Note that this seems to have been implemented now. (Not sure which patch/bug). Pressing `Esc` on the dedicated search button returns focus to the urlbar. > 3. After bug 1086524, pressing escape on the address bar focuses the document. This is consistent with other browsers. I personally don't entirely follow the logic for this - yes, it's an input, but it's not a pop-up - but I guess it makes some sense if you think of the address bar as a modal with regard to how keyboard users interact with it. I focus the Adress bar by pressing `Ctrl + L`. Having some way (`Esc`) to return back to the document somehow feels natural to me too. > 4. Pressing escape on toolbar buttons in other browsers does nothing. I find that a bit inconsistent and I don't think we need to follow their example. I feel like this is not a design decision, but a current oversight in the UX for keyboard users that might get fixed by other browsers in the future too. > 5. Given that there's no established convention here, having escape do something when focused on a toolbar button isn't going to hurt anyone. However, this would be an enhancement, not a defect. I agree. > 6. I don't think it makes sense for escape on any toolbar button to focus the address bar. For example, I can't logically explain why pressing escape on the Bookmark button should focus the address bar. I agree. This Bug was initially for the dedicated search button. For other parts in the URL it probably makes sense to focus the document as well (e.g. from the search bar / back button, and maybe even other items within the urlbar. > 7. Having escape focus the document would be consistent with (3). 👍, haven't read that before writing (6). I fully agree.
(In reply to James Teh [:Jamie] from comment #5) > 1. Why do you think escape should return focus to the address bar? Can you explain the rationale here? > 2. In the majority of cases, escape dismisses a pop-up. From what I can tell, when you focus the unified search button, the address bar is always collapsed, so no pop-up is open and this doesn't apply. The dedicated search button is part of the urlbar. When I enter text to search something and select a suggestion with `Tab`, I can remove that selection by pressing `Esc`. The dedicated search button is in the `Tab` order of the search suggestion menu, therefore I expect I can remove the focus back to the urlbar when pressing `Esc` if it had previously focus. Note that this seems to have been implemented now. (Not sure which patch/bug). Pressing `Esc` on the dedicated search button returns focus to the urlbar. > 3. After bug 1086524, pressing escape on the address bar focuses the document. This is consistent with other browsers. I personally don't entirely follow the logic for this - yes, it's an input, but it's not a pop-up - but I guess it makes some sense if you think of the address bar as a modal with regard to how keyboard users interact with it. I focus the Adress bar by pressing `Ctrl + L`. Having some way (`Esc`) to return back to the document somehow feels natural to me too. > 4. Pressing escape on toolbar buttons in other browsers does nothing. I find that a bit inconsistent and I don't think we need to follow their example. I feel like this is not a design decision, but a current oversight in the UX for keyboard users that might get fixed by other browsers in the future too. > 5. Given that there's no established convention here, having escape do something when focused on a toolbar button isn't going to hurt anyone. However, this would be an enhancement, not a defect. I agree. > 6. I don't think it makes sense for escape on any toolbar button to focus the address bar. For example, I can't logically explain why pressing escape on the Bookmark button should focus the address bar. I agree. This Bug was initially for the dedicated search button. For other parts in the URL it probably makes sense to focus the document instead (e.g. from the search bar / back button, and maybe even other items within the urlbar. > 7. Having escape focus the document would be consistent with (3). 👍, haven't read that before writing (6). I fully agree.