2. not show menu options that allow saving tab groups when in a private window(In reply to Dão Gottwald [:dao] from comment #3) > (In reply to Stephen Thompson [:sthompson] from comment #0) > > Explicitly saving a tab group has the potential to store information beyond the lifetime of the private window. > > This is true for adding a bookmark from a private window as well, although that's only URLs and titles, whereas we store more information with groups. > > > The result of all of this suggests to me that we should > > 1. not show saved tab groups in private windows in any context > > Agreed, given that after being open in a private window, they wouldn't get auto-saved when closing that window. > > > 2. not show menu options that allow saving tab groups when in a private window > > This is a tough one. Given how we handle bookmarking in private windows, I tend to think it would in principle make sense to allow users to save and close groups from private windows. However, it might be confusing to then be unable to find a group right after saving it due saved groups not being offered in private windows (point 1 above). This problem doesn't exist for bookmarks, since we can surface those in private windows without the risk of losing them when closing the window. > > > 3. suppress any other mechanisms (like auto-saving tab groups in a window on window close) that would result in a tab group being saved from a private window > > Agreed. "2. not show menu options that allow saving tab groups when in a private window" I agree and this was the in the original spec for private windows https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping-Spec?node-id=9545-332596&t=fypdPh01LsaYUPYY-1 In private windows, there would not be a "tab groups" section in the TOM menu (this is because all items there represent saved tab groups). We will display the tab group in the opened tabs section below it. If a user opens a new private window (private window 2) and opens a new tab, they can still right-click to move the tab to private window 1 but like I said, the "tab groups" section in the TOM would not exist in private windows.
Bug 1933112 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
2. not show menu options that allow saving tab groups when in a private window(In reply to Dão Gottwald [:dao] from comment #3) > (In reply to Stephen Thompson [:sthompson] from comment #0) > > Explicitly saving a tab group has the potential to store information beyond the lifetime of the private window. > > This is true for adding a bookmark from a private window as well, although that's only URLs and titles, whereas we store more information with groups. > > > The result of all of this suggests to me that we should > > 1. not show saved tab groups in private windows in any context > > Agreed, given that after being open in a private window, they wouldn't get auto-saved when closing that window. > > > 2. not show menu options that allow saving tab groups when in a private window > > This is a tough one. Given how we handle bookmarking in private windows, I tend to think it would in principle make sense to allow users to save and close groups from private windows. However, it might be confusing to then be unable to find a group right after saving it due saved groups not being offered in private windows (point 1 above). This problem doesn't exist for bookmarks, since we can surface those in private windows without the risk of losing them when closing the window. > > > 3. suppress any other mechanisms (like auto-saving tab groups in a window on window close) that would result in a tab group being saved from a private window > > Agreed. "2. not show menu options that allow saving tab groups when in a private window" I agree and this was the in the original spec for private windows https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping-Spec?node-id=9545-332596&t=fypdPh01LsaYUPYY-1 In private windows, there would not be a "tab groups" section in the TOM menu (this is because all items there represent saved tab groups). We will display the tab group in the opened tabs section below it. If a user opens a new private window (private window 2) and opens a new tab, they can still right-click to move the tab to private window 1 IF the tab group is currently opened in private window 1.
2. not show menu options that allow saving tab groups when in a private window(In reply to Dão Gottwald [:dao] from comment #3) > (In reply to Stephen Thompson [:sthompson] from comment #0) > > Explicitly saving a tab group has the potential to store information beyond the lifetime of the private window. > > This is true for adding a bookmark from a private window as well, although that's only URLs and titles, whereas we store more information with groups. > > > The result of all of this suggests to me that we should > > 1. not show saved tab groups in private windows in any context > > Agreed, given that after being open in a private window, they wouldn't get auto-saved when closing that window. > > > 2. not show menu options that allow saving tab groups when in a private window > > This is a tough one. Given how we handle bookmarking in private windows, I tend to think it would in principle make sense to allow users to save and close groups from private windows. However, it might be confusing to then be unable to find a group right after saving it due saved groups not being offered in private windows (point 1 above). This problem doesn't exist for bookmarks, since we can surface those in private windows without the risk of losing them when closing the window. > > > 3. suppress any other mechanisms (like auto-saving tab groups in a window on window close) that would result in a tab group being saved from a private window > > Agreed. "2. not show menu options that allow saving tab groups when in a private window" I agree and this was the in the original spec for private windows https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping-Spec?node-id=9545-332596&t=fypdPh01LsaYUPYY-1 In private windows, there would not be a "tab groups" section in the TOM menu (this is because all items there represent saved tab groups). We will display the tab group in the opened tabs section below it. If a user opens a new private window (private window 2) and opens a new tab, they can still right-click to move the tab to a group in private window 1 IF the tab group is currently opened in private window 1.