Bugzilla

(In reply to Ben Campbell from comment #21)
> (In reply to Kai Engert [:KaiE:] from comment #20)
> > It's my example mbox (a Trash folder) that has many messages.
> 
> So how/when was that one generated? I'm assuming it's IMAP, right?

The messages in that folder, which are missing From, are from 2023-10 and 2024-04


> I'm trying to figure out if it was a long-standing issue, or if it happened with the new mbox code (which would be worrying - the whole idea was to factor out the mbox code so that writing was done in only one place, and correctly, so it should be impossible to write to an mbox without the code automatically inserting "From " markers).
> 
> (In reply to Alessandro Castellani [:aleca] from comment #19)
> > > how/when was this mbox file generated?
> > 
> > March 2024, during the 115 cycle.
> > This is from the profile I use exclusively with ESR.
> 
> OK, so that case must have been pre-mbox-refactor, which means there were code paths then that generated borked mbox files.
> Poop.
> On the bright side, it was probably just wrong for some specific code path for IMAP, so the comment 7 suggestion would do the trick.
> 
> The _easiest_ fix would be just to make sure the compactor fail with an identifiable error code (probably `NS_MSG_ERROR_MBOX_MALFORMED`), and catch it here:
> https://searchfox.org/comm-central/source/mailnews/base/src/FolderCompactor.cpp#717
> The existing errors are just handled by telling the folder to pop up an error dialog. We could just pop up a message to tell the user we can't compact the folder until they perform a repair (a bit of a cop out).
> I don't quite know how we ask the user and then safely kick off a folder repair _within_ the context of the compaction...  I suspect it'd be cleaner to do that further up the stack (as a general rule, I think doing any interactive GUI stuff from the C++ side tends to be a bad thing)
> 
> So, first off, how widespread an issue is this likely to be (do we have any other reports coming in?). Is it enough to just show a message prompting the user to do an IMAP repair themselves?

(In reply to Ben Campbell from comment #21)
> (In reply to Kai Engert [:KaiE:] from comment #20)
> > It's my example mbox (a Trash folder) that has many messages.
> 
> So how/when was that one generated? I'm assuming it's IMAP, right?

The messages in that folder, which are missing From, are from 2023-10 and 2024-04