(In reply to Brad Werth [:bradwerth] from comment #55) > Created attachment 9472501 [details] > WIP: Bug 1941595: Make nsMenuBarX::PaintAsync into a sync method for macOS versions macOS 14 and later. > > > This is attempting to do an effective backout of Bug 1765391, which > added the PaintAsync method. That was the working part of that Bug, and > it was presumed to be the source of the grey/disabled appearance that > provoked *this* Bug. Unfortunately, local builds with this patch applied > still show the grey menubar behavior. Are you sure the `@available` keyword's value changes according to which macOS version is running? It may have to do with the macOS version on which the binary (`XUL`) was built. There's already an [`nsCocoaFeatures::OnVenturaOrLater()`](https://searchfox.org/mozilla-central/source/widget/cocoa/nsCocoaFeatures.mm#178) that does what you need.
Bug 1941595 Comment 56 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Brad Werth [:bradwerth] from comment #55) > Created attachment 9472501 [details] > WIP: Bug 1941595: Make nsMenuBarX::PaintAsync into a sync method for macOS versions macOS 14 and later. > > > This is attempting to do an effective backout of Bug 1765391, which > added the PaintAsync method. That was the working part of that Bug, and > it was presumed to be the source of the grey/disabled appearance that > provoked *this* Bug. Unfortunately, local builds with this patch applied > still show the grey menubar behavior. Are you sure the `@available` keyword's value changes according to which macOS version is running? It may have to do with the macOS version on which the binary (`XUL`) was built. There's already an [`nsCocoaFeatures::OnVenturaOrLater()`](https://searchfox.org/mozilla-central/source/widget/cocoa/nsCocoaFeatures.mm#178) method that checks what version of macOS is running. You can use it as a template for a new `nsCocoaFeatures::OnSonomaOrLater()` method.
(In reply to Brad Werth [:bradwerth] from comment #55) > Created attachment 9472501 [details] > WIP: Bug 1941595: Make nsMenuBarX::PaintAsync into a sync method for macOS versions macOS 14 and later. > > > This is attempting to do an effective backout of Bug 1765391, which > added the PaintAsync method. That was the working part of that Bug, and > it was presumed to be the source of the grey/disabled appearance that > provoked *this* Bug. Unfortunately, local builds with this patch applied > still show the grey menubar behavior. Are you sure the `@available` keyword's value changes according to which macOS version is running? It may have to do with the macOS version on which the binary (`XUL`) was built. There's already an [`nsCocoaFeatures::OnVenturaOrLater()`](https://searchfox.org/mozilla-central/source/widget/cocoa/nsCocoaFeatures.mm#178) method that checks which version of macOS is running. You can use it as a template for a new `nsCocoaFeatures::OnSonomaOrLater()` method.