(In reply to Hiroyuki Ikezoe (:hiro) from comment #28) > Something has been totally broken since bug 1988730. > > When the software keyboard is shown, [Fenix forcibly set the dynamic toolbar max height to zero](https://searchfox.org/firefox-main/rev/7d8644b9d4470a675bf670c2dc7664cc01f14ece/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt#108), the code was introduced in bug 1988730. It disables the dynamic toolbar, which means it breaks one of the advantages of interactive-widget=resize-visual mode since it causes full reflow. > > We need to stop doing it. CCing :petru. > > I will take a deep look again later. So keep NI to me. I'm open to suggestions on how otherwise to keep the toolbar fixed when the user is entering text in a website. Technically when this happens we currently configure the toolbar as it was fixed in place - not dynamic. Current behaviour (visual) matches what Chrome does and was requested by product.
Bug 1943053 Comment 30 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #28) > Something has been totally broken since bug 1988730. > > When the software keyboard is shown, [Fenix forcibly set the dynamic toolbar max height to zero](https://searchfox.org/firefox-main/rev/7d8644b9d4470a675bf670c2dc7664cc01f14ece/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt#108), the code was introduced in bug 1988730. It disables the dynamic toolbar, which means it breaks one of the advantages of interactive-widget=resize-visual mode since it causes full reflow. > > We need to stop doing it. CCing :petru. > > I will take a deep look again later. So keep NI to me. I'm open to suggestions on how otherwise to keep the toolbar fixed when the user is entering text in a website. Technically when this happens we currently configure the toolbar as it was fixed in place - not dynamic. Current behaviour (visual) matches what Chrome does and was requested by product. Maybe we'd need a callback into APZ to request a special kind of reflow which would help in these specific scenarios?
(In reply to Hiroyuki Ikezoe (:hiro) from comment #28) > Something has been totally broken since bug 1988730. > > When the software keyboard is shown, [Fenix forcibly set the dynamic toolbar max height to zero](https://searchfox.org/firefox-main/rev/7d8644b9d4470a675bf670c2dc7664cc01f14ece/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt#108), the code was introduced in bug 1988730. It disables the dynamic toolbar, which means it breaks one of the advantages of interactive-widget=resize-visual mode since it causes full reflow. > > We need to stop doing it. CCing :petru. > > I will take a deep look again later. So keep NI to me. I'm open to suggestions on how otherwise to keep the toolbar fixed when the user is entering text in a website. Technically when this happens we currently configure the toolbar as it was fixed in place - not dynamic. Current behaviour (visual) matches what Chrome does and was requested by product. Maybe we'd need a callback into APZ to request a special kind of reflow which would help in these specific scenarios? For context: there is a tentative plan to also show a minimal toolbar at the top while entering text and then also show a minimal toolbar instead of the full one whenever the being page is scrolled. We'd definitely need the layout to easily adapt to the changes in toolbar heights.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #28) > Something has been totally broken since bug 1988730. > > When the software keyboard is shown, [Fenix forcibly set the dynamic toolbar max height to zero](https://searchfox.org/firefox-main/rev/7d8644b9d4470a675bf670c2dc7664cc01f14ece/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt#108), the code was introduced in bug 1988730. It disables the dynamic toolbar, which means it breaks one of the advantages of interactive-widget=resize-visual mode since it causes full reflow. > > We need to stop doing it. CCing :petru. > > I will take a deep look again later. So keep NI to me. I'm open to suggestions on how otherwise to keep the toolbar fixed when the user is entering text in a website. Technically when this happens we currently configure the toolbar as it was fixed in place - not dynamic. Current behaviour (visual) matches what Chrome does and was requested by product. Maybe we'd need a callback into APZ to request a special kind of reflow which would help in these specific scenarios? For context: there is a tentative plan to also show a minimal toolbar at the top while entering text and then also show a minimal toolbar instead of the full one whenever the page is being scrolled. We'd definitely need the layout to easily adapt to the changes in toolbar heights.