Bugzilla

(In reply to Petru-Mugurel Lingurar [:petru] from comment #30)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #28)
> > Something has been totally broken since bug 1988730.
> > 
> > When the software keyboard is shown, [Fenix forcibly set the dynamic toolbar max height to zero](https://searchfox.org/firefox-main/rev/7d8644b9d4470a675bf670c2dc7664cc01f14ece/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt#108), the code was introduced in bug 1988730. It disables the dynamic toolbar, which means it breaks one of the advantages of interactive-widget=resize-visual mode since it causes full reflow.  
> > 
> > We need to stop doing it. CCing :petru.
> > 
> > I will take a deep look again later. So keep NI to me.
> 
> I'm open to suggestions on how otherwise to keep the toolbar fixed when the user is entering text in a website.
> Technically when this happens we currently configure the toolbar as it was fixed in place - not dynamic.
> Current behaviour (visual) matches what Chrome does and was requested by product.

Yeah at first glance it looks like it matches Chrome's behavior but in fact it doesn't match Chrome's behavior as a web browser unfortunately.

> Maybe we'd need a callback into APZ to request a special kind of reflow which would help in these specific scenarios?

I don't think it solve this issue at all. With interactive-widget=resizes-visual or interactive-widget=overlays-content any reflow should be triggered by the browser.

I'd suggest backing bug 1988730 out for now.

(In reply to Petru-Mugurel Lingurar [:petru] from comment #30)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #28)
> > Something has been totally broken since bug 1988730.
> > 
> > When the software keyboard is shown, [Fenix forcibly set the dynamic toolbar max height to zero](https://searchfox.org/firefox-main/rev/7d8644b9d4470a675bf670c2dc7664cc01f14ece/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarsIntegration.kt#108), the code was introduced in bug 1988730. It disables the dynamic toolbar, which means it breaks one of the advantages of interactive-widget=resize-visual mode since it causes full reflow.  
> > 
> > We need to stop doing it. CCing :petru.
> > 
> > I will take a deep look again later. So keep NI to me.
> 
> I'm open to suggestions on how otherwise to keep the toolbar fixed when the user is entering text in a website.
> Technically when this happens we currently configure the toolbar as it was fixed in place - not dynamic.
> Current behaviour (visual) matches what Chrome does and was requested by product.

Yeah at first glance it looks like it matches Chrome's behavior but in fact it doesn't match Chrome's behavior as a web browser unfortunately.

> Maybe we'd need a callback into APZ to request a special kind of reflow which would help in these specific scenarios?

I don't think it solve this issue at all. With interactive-widget=resizes-visual or interactive-widget=overlays-content any reflow should NOT be triggered by the browser.

I'd suggest backing bug 1988730 out for now.