Bug 1944433 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Aaron Train [:aaronmt]

on 2025-01-28 16:04:32 PST

[Tracking Requested - why for this release]: Crash on private browsing settings access

Reproducible manually by opening the Private Browsing settings sub-menu by just reading the stacks above. 

Reflecting that this is actually a crash.


```
01-28 13:47:18.940 12186 12186 D AndroidRuntime: Shutting down VM
01-28 13:47:18.942 12186 12186 E AndroidRuntime: FATAL EXCEPTION: main
01-28 13:47:18.942 12186 12186 E AndroidRuntime: Process: org.mozilla.fenix.debug, PID: 12186
01-28 13:47:18.942 12186 12186 E AndroidRuntime: java.lang.IllegalArgumentException: Required value was null.
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.ExtensionsKt.requirePreference(Extensions.kt:87)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.PrivateBrowsingFragment.updatePreferences(PrivateBrowsingFragment.kt:60)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.PrivateBrowsingFragment.onCreatePreferences(PrivateBrowsingFragment.kt:29)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.preference.PreferenceFragmentCompat.onCreate(PreferenceFragmentCompat.java:161)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.Fragment.performCreate(Fragment.java:3099)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:524)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2214)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2115)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2052)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:703)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:958)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:205)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:294)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8177)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)
```

Revision 1 by

Aaron Train [:aaronmt]

on 2025-01-28 16:20:53 PST

[Tracking Requested - why for this release]: Crash on private browsing settings access

Reproducible manually by opening the Private Browsing settings sub-menu 

Reflecting that this is actually a crash.


```
01-28 13:47:18.940 12186 12186 D AndroidRuntime: Shutting down VM
01-28 13:47:18.942 12186 12186 E AndroidRuntime: FATAL EXCEPTION: main
01-28 13:47:18.942 12186 12186 E AndroidRuntime: Process: org.mozilla.fenix.debug, PID: 12186
01-28 13:47:18.942 12186 12186 E AndroidRuntime: java.lang.IllegalArgumentException: Required value was null.
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.ExtensionsKt.requirePreference(Extensions.kt:87)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.PrivateBrowsingFragment.updatePreferences(PrivateBrowsingFragment.kt:60)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.PrivateBrowsingFragment.onCreatePreferences(PrivateBrowsingFragment.kt:29)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.preference.PreferenceFragmentCompat.onCreate(PreferenceFragmentCompat.java:161)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.Fragment.performCreate(Fragment.java:3099)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:524)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2214)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2115)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2052)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:703)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:958)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:205)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:294)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8177)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)
```

Revision 2 by

Aaron Train [:aaronmt]

on 2025-01-28 16:21:03 PST

[Tracking Requested - why for this release]: Crash on private browsing settings access

Reproducible manually by opening the Private Browsing settings sub-menu 

```
01-28 13:47:18.940 12186 12186 D AndroidRuntime: Shutting down VM
01-28 13:47:18.942 12186 12186 E AndroidRuntime: FATAL EXCEPTION: main
01-28 13:47:18.942 12186 12186 E AndroidRuntime: Process: org.mozilla.fenix.debug, PID: 12186
01-28 13:47:18.942 12186 12186 E AndroidRuntime: java.lang.IllegalArgumentException: Required value was null.
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.ExtensionsKt.requirePreference(Extensions.kt:87)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.PrivateBrowsingFragment.updatePreferences(PrivateBrowsingFragment.kt:60)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at org.mozilla.fenix.settings.PrivateBrowsingFragment.onCreatePreferences(PrivateBrowsingFragment.kt:29)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.preference.PreferenceFragmentCompat.onCreate(PreferenceFragmentCompat.java:161)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.Fragment.performCreate(Fragment.java:3099)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:524)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2214)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2115)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2052)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:703)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:958)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:205)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:294)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8177)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
01-28 13:47:18.942 12186 12186 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)
```

Back to Bug 1944433 Comment 2