Bug 1945819 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I retested this today (just in case the site happened to have changed in a way that avoids this).

This is still reproducible, at https://500px.com/popular (the URL has changed since comment 0).

Here's why this site hits the 9999-grid-row-limit so easily: they have 1px-tall grid-rows.

Specifically:
 - they have 5 equally-sized columns (on my current Firefox window at least): `grid-template-columns: repeat(5, 1fr);`
 - ...but the grid rows are 1px tall (and generated as-needed based on the content): `grid-auto-rows: 1px`
 - ...and they use grid auto-placement to place images into the grid, using e.g. `grid-row: span 300` for an image that they'd like to be 300px tall (so it spans 300 1px-tall-rows, which makes it 300px tall, and avoids colliding with other auto-placed images).

Given that -- with most images being in the ballpark of 300px tall, they only end up being able to have ~34 rows of children before they hit the 9999 track limit (because each 300px child is roughly 300 rows in height, and 33 * 300 = 9900).
I retested this today (just in case the site happened to have changed in a way that avoids this).

This is still reproducible, at https://500px.com/popular (the URL has changed since comment 0).

Here's why this site hits the 9999-grid-row-limit so easily: they have 1px-tall grid-rows.

Specifically:
 - they have 5 equally-sized columns (on my current Firefox window at least): `grid-template-columns: repeat(5, 1fr);`
 - ...but the grid rows are 1px tall (and generated as-needed based on the content): `grid-auto-rows: 1px`
 - ...and they use grid auto-placement to place images into the grid, using e.g. `grid-row: span 300` for an image that they'd like to be 300px tall (so it spans 300 1px-tall-rows, which makes it 300px tall, and avoids colliding with other auto-placed images).

Given that -- with most images being in the ballpark of 300px tall, this site only ends up being able to have ~33 rows of children before they hit the 9999 track limit (because each 300px child is roughly 300 rows in height, and 33 * 300 = 9900).

Back to Bug 1945819 Comment 9