Thanks for filing this. The errors a real bug, a regression from bug 1952588 and bug 1946621. They shouldn't stop Firefox from working properly though, as you found out. When I run new profile with a build before bug 1952588 landed and then run it with a build with bug 1952588 fixed, I see: ``` [ERROR error_support::handling] suggest-unexpected: Error executing SQL: UNIQUE constraint failed: keywords_metrics.record_id (context: keyword metrics insert) [ERROR error_support::handling] suggest-unexpected: Error executing SQL: UNIQUE constraint failed: yelp_subjects.keyword (context: <none>) ``` The problem is the DB remains populated with the data from the old `quicksuggest` collection when the store tries to insert data from the new collections. That violates uniqueness constraints in tables where the unique data comes directly from the records, like record IDs. Normally this isn't a problem because, before inserting new data, the store removes rows from the DB that came from deleted and updated records. It's a problem now because the collections are different, and after bug 1952588 the `SuggestStore` doesn't know anything about the old collection anymore, and none of the suggestions tables keep track of which collection their rows came from. Record IDs yes, collections no.
Bug 1953945 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks for filing this. The errors are a real bug, a regression from bug 1952588 and bug 1946621. They shouldn't stop Firefox from working properly though, as you found out. When I run new profile with a build before bug 1952588 landed and then run it with a build with bug 1952588 fixed, I see: ``` [ERROR error_support::handling] suggest-unexpected: Error executing SQL: UNIQUE constraint failed: keywords_metrics.record_id (context: keyword metrics insert) [ERROR error_support::handling] suggest-unexpected: Error executing SQL: UNIQUE constraint failed: yelp_subjects.keyword (context: <none>) ``` The problem is the DB remains populated with the data from the old `quicksuggest` collection when the store tries to insert data from the new collections. That violates uniqueness constraints in tables where the unique data comes directly from the records, like record IDs. Normally this isn't a problem because, before inserting new data, the store removes rows from the DB that came from deleted and updated records. It's a problem now because the collections are different, and after bug 1952588 the `SuggestStore` doesn't know anything about the old collection anymore, and none of the suggestions tables keep track of which collection their rows came from. Record IDs yes, collections no.