afaict (but i might be wrong), looking closely at the various diffs posted, at least in https://phabricator.services.mozilla.com/D264889, the ffmpeg62 dir is just a straight copy of ffmpeg61, which to my understanding isn't the right way to go. https://bugzilla.mozilla.org/attachment.cgi?id=9524599 looks like a proper vendoring of the ffmpeg8 headers, but with (clang ? some?) formatting applied ? (checked by diffing the ffmpeg62 dir with an installed copy of ffmpeg 8.0) in bug #1889978, the ffmpeg headers were added to clang-format-ignore, prettierignore and tools/rewriting/ThirdPartyPaths.txt (cf https://phabricator.services.mozilla.com/D206922#7160780 and https://hg-edge.mozilla.org/integration/autoland/rev/5970587d9a7a), should the same be done ?
Bug 1962139 Comment 25 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
afaict (but i might be wrong), looking closely at the various diffs posted, at least in https://phabricator.services.mozilla.com/D264889, the ffmpeg62 dir is just a straight copy of ffmpeg61, which to my understanding isn't the right way to go. https://bugzilla.mozilla.org/attachment.cgi?id=9524599 looks like a proper vendoring of the ffmpeg8 headers, but with (clang ? some?) formatting applied ? (checked by diffing the ffmpeg62 dir with an installed copy of ffmpeg 8.0) - and adding of the mozilla licence header to please some mozilla tool ? ``` +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ ``` in bug #1889978, the ffmpeg headers were added to clang-format-ignore, prettierignore and tools/rewriting/ThirdPartyPaths.txt (cf https://phabricator.services.mozilla.com/D206922#7160780 and https://hg-edge.mozilla.org/integration/autoland/rev/5970587d9a7a), should the same be done ?