Bug 1971994 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I suspect the data blob lifecycle is not managed properly, we GetBlob from the database, that hands us ownership of a data buffer, later code stores that in some IconInfo structs... and I suspect when the data is not effectively assigned to an owning ref pointer, it will get leaked.
We must audit the GetBlob calls in FaviconHelpers.cpp and ensure there's clear ownership of the data buffer, or that we free it when it's not necessary anymore.
We should also check how we can better track this memory.
I suspect the data blob lifecycle is not managed properly, we GetBlob from the database, that hands us ownership of a data buffer, later code stores that in some IconInfo structs... and I suspect when the data is not effectively assigned to an owning ref pointer it will get leaked.
We must audit the GetBlob calls in FaviconHelpers.cpp and ensure there's clear ownership of the data buffer, or that we free it when it's not necessary anymore.
We should also check how we can better track this memory.

Back to Bug 1971994 Comment 5