Bug 1975790 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Adding onto [this patch](https://phabricator.services.mozilla.com/D255555), we need to remove the `joinBlocking()` calls in `WebCompatReporterTelemetryMiddlewareTest.kt` since our `WebCompatReporterStore` is a `UI Store` since this means we no longer need to block the test thread waiting for a background job to finish.
Adding onto [this patch](https://phabricator.services.mozilla.com/D255555#8854280), we need to remove the `joinBlocking()` calls in `WebCompatReporterTelemetryMiddlewareTest.kt` since our `WebCompatReporterStore` is a `UI Store` since this means we no longer need to block the test thread waiting for a background job to finish.
Adding onto [this patch](https://phabricator.services.mozilla.com/D255555#8854280), we need to remove the `joinBlocking()` calls in `WebCompatReporterTelemetryMiddlewareTest.kt` since our `WebCompatReporterStore` is a `UI Store`, which dispatches actions and updates state synchronously on the main thread. That means there’s no background coroutine to wait for, so we can safely remove the now-unused joinBlocking() calls from WebCompatReporterTelemetryMiddlewareTest.kt.
Adding onto [this patch](https://phabricator.services.mozilla.com/D255555#8854280), we need to remove the `joinBlocking()` calls in `WebCompatReporterTelemetryMiddlewareTest.kt` since our `WebCompatReporterStore` is a `UI Store`, which dispatches actions and updates state synchronously on the main thread. That means there’s no background coroutine to wait for, so we can safely remove the now unused joinBlocking() calls from WebCompatReporterTelemetryMiddlewareTest.kt.
Adding onto [this patch](https://phabricator.services.mozilla.com/D255555#8854280), we need to remove the `joinBlocking()` calls in `WebCompatReporterTelemetryMiddlewareTest.kt` since our `WebCompatReporterStore` is a `UI Store`, which guarantees that dispatch() processes actions and updates state immediately on the main thread. Because of this, we no longer need to call joinBlocking() in `WebCompatReporterTelemetryMiddlewareTest.kt` as the state changes are already applied synchronously.
Adding onto [this patch](https://phabricator.services.mozilla.com/D255555#8854280), we need to remove the `joinBlocking()` calls in `WebCompatReporterTelemetryMiddlewareTest.kt` since our `WebCompatReporterStore` is a `UI Store`, which guarantees that dispatch() processes actions and updates state immediately on the main thread. Because of this, we no longer need to call joinBlocking() in `WebCompatReporterTelemetryMiddlewareTest.kt` as the state changes are already applied synchronously. Here is a [sf](https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/lib/state/src/main/java/mozilla/components/lib/state/UiStore.kt#11) link for more context on the UI Store.

Back to Bug 1975790 Comment 0