Bug 1978136 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Hi Emilio,
This bug seems relating to bug 1974517.
`CreateWidget()` in GtkWidgets.cpp return `nullptr` for `Type::ScrollbarThumb`.
According to the crash report, `nsLookAndFeel::PerThemeData::Init()` [1] on the stack will cause calling `CreateWidget()` with this type.
It eventually calls `gtk_style_context_get_path()` passing 'NULL` as an argument, causing the crash.

[1] https://hg-edge.mozilla.org/mozilla-central/file/8b0d004a4d3f03394d1e7072f95d95a65415a0dc/widget/gtk/nsLookAndFeel.cpp#l2216
Revision 1 by
on 
Hi Emilio,
This bug seems relating to bug 1974517.
`CreateWidget()` in GtkWidgets.cpp return `nullptr` for `Type::ScrollbarThumb`.
According to the crash report, `nsLookAndFeel::PerThemeData::Init()` [1] on the stack will cause calling `CreateWidget()` with this type.
It eventually calls `gtk_style_context_get_path()` passing 'NULL` as an argument, causing the crash.
I have checked out the code of gtk-3.14.0 to check `gtk_style_context_get_path()`. The first thing it does is to dereference `context` it's argument.
That is `NULL`.

[1] https://hg-edge.mozilla.org/mozilla-central/file/8b0d004a4d3f03394d1e7072f95d95a65415a0dc/widget/gtk/nsLookAndFeel.cpp#l2216
Revision 2 by
on 
Hi Emilio,
This bug seems relating to bug 1973702.
`CreateWidget()` in GtkWidgets.cpp return `nullptr` for `Type::ScrollbarThumb`.
According to the crash report, `nsLookAndFeel::PerThemeData::Init()` [1] on the stack will cause calling `CreateWidget()` with this type.
It eventually calls `gtk_style_context_get_path()` passing 'NULL` as an argument, causing the crash.
I have checked out the code of gtk-3.14.0 to check `gtk_style_context_get_path()`. The first thing it does is to dereference `context` it's argument.
That is `NULL`.

[1] https://hg-edge.mozilla.org/mozilla-central/file/8b0d004a4d3f03394d1e7072f95d95a65415a0dc/widget/gtk/nsLookAndFeel.cpp#l2216
Revision 3 by
on 
Hi Emilio,
This bug seems relating to bug 1973702.
`CreateWidget()` in GtkWidgets.cpp return `nullptr` for `Type::ScrollbarThumb`.
According to the crash report, `nsLookAndFeel::PerThemeData::Init()` [1] on the stack will cause calling `CreateWidget()` with this type.
It eventually calls `gtk_style_context_get_path()` passing `NULL` as an argument, causing the crash.
I have checked out the code of gtk-3.14.0 to check `gtk_style_context_get_path()`. The first thing it does is to dereference `context` it's argument.
That is `NULL`.

[1] https://hg-edge.mozilla.org/mozilla-central/file/8b0d004a4d3f03394d1e7072f95d95a65415a0dc/widget/gtk/nsLookAndFeel.cpp#l2216

Back to Bug 1978136 Comment 1