GetStatementOnHelperThread should probably check mIsConnectionReady before trying to use mHelperThreadStatements. GetCachedStatement should probably hold sharedAsyncExecutionMutex, because it looks like the connection is being teared down.
Bug 1986816 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
GetStatementOnHelperThread should probably check mIsConnectionReady before trying to use mHelperThreadStatements. ~~GetCachedStatement should probably hold sharedAsyncExecutionMutex, because it looks like the connection is being teared down.~~ <= this is not necessary, StatementCache doesn't own the connection and relies on the consumer to properly handle teardown.